Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Kagan <rkagan@virtuozzo.com>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
CC:     "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Sasha Levin <sashal@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v3] x86/hyper-v: micro-optimize send_ipi_one case
Thread-Topic: [PATCH v3] x86/hyper-v: micro-optimize send_ipi_one case
Thread-Index: AQHVjNn473X+0wGhnUOCRzZ/uvX6C6dvzGgA
Date:   Mon, 28 Oct 2019 09:35:42 +0000
Message-ID: <20191028093538.GA9711@rkaganb.sw.ru>
References: <20191027151938.7296-1-vkuznets@redhat.com>
In-Reply-To: <20191027151938.7296-1-vkuznets@redhat.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
user-agent: Mutt/1.12.1 (2019-06-15)
mail-followup-to: Roman Kagan <rkagan@virtuozzo.com>,   Vitaly Kuznetsov
 <vkuznets@redhat.com>, linux-hyperv@vger.kernel.org,
 linux-kernel@vger.kernel.org,  x86@kernel.org, "K. Y. Srinivasan"
 <kys@microsoft.com>,   Haiyang Zhang <haiyangz@microsoft.com>, Stephen
 Hemminger <sthemmin@microsoft.com>,    Sasha Levin <sashal@kernel.org>,        Thomas
 Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav
 Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,       Michael Kelley
 <mikelley@microsoft.com>,      Joe Perches <joe@perches.com>
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 395f6612-ea38-494f-386c-08d75b8a33ac
x-ms-traffictypediagnostic: AM4PR0802MB2276:
x-microsoft-antispam-prvs: <AM4PR0802MB22768A009B1890C9661B3641C9660@AM4PR0802MB2276.eurprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0204F0BDE2
x-forefront-antispam-report: SFV:SPM;SFS:(10019020)(136003)(376002)(346002)(396003)(366004)(39840400004)(199004)(189003)(71190400001)(71200400001)(186003)(26005)(11346002)(6506007)(446003)(486006)(25786009)(476003)(102836004)(478600001)(33656002)(386003)(81166006)(66066001)(5660300002)(1076003)(4744005)(66946007)(66446008)(64756008)(66556008)(14454004)(52116002)(66476007)(76176011)(99286004)(6116002)(36756003)(4326008)(8936002)(86362001)(3846002)(6916009)(54906003)(58126008)(316002)(7416002)(7736002)(14444005)(256004)(6512007)(6246003)(9686003)(305945005)(8676002)(6436002)(6486002)(81156014)(2906002)(229853002)(30126002);DIR:OUT;SFP:1501;SCL:5;SRVR:AM4PR0802MB2276;H:AM4PR0802MB2242.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: virtuozzo.com does not designate
 permitted sender hosts)
x-ms-exchange-transport-forked: True
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: f+BlratBuPpvYCO8uSJWZ1dVMNt78bi0UsXWPOGrINwAJ0vaTOY/9DqmgM+5NB65wOr0zJEU173jPpT3B7DONevbOdLFPT4hVHN+vpvCjAvQrn2gzj5w7NEjNvJcEzsCT8r5UpVR41a1Z7xp2HwQpV1ajA/o0IfmP4+3MeKLqsZzlhI6NDT2xTkzxZqWATQf2IlSstCSEzu0ndCXNU7Dt4wgUQOfhnIlyykV5vIiOkW7ULe8koycgadfXmIYIQOBryxAFf0/fLddSpn/GL0fxR9Z3dwe3HLdRHrZLSYRniQzvDW/vGHn8DQC7O7fDxpA+GO3fMSdN0IcuI1+Mn/Wi4nK44EdMXSA7yhcl/4diK8pfe0wFn7I8XgOkVPwgWan
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89B8387013B49445A75278895B07D0C5@eurprd08.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 395f6612-ea38-494f-386c-08d75b8a33ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2019 09:35:42.9032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +M2mNKIsBakrUX6Y4kq5ksbs2Mbn7CpQKJo6W/hlzqu/Axs3EbdHHhnuKKvVujinkYKoXHJiHQKQfuuKLVwmnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2276
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 27, 2019 at 04:19:38PM +0100, Vitaly Kuznetsov wrote:
> When sending an IPI to a single CPU there is no need to deal with cpumasks.
> With 2 CPU guest on WS2019 I'm seeing a minor (like 3%, 8043 -> 7761 CPU
> cycles) improvement with smp_call_function_single() loop benchmark. The
> optimization, however, is tiny and straitforward. Also, send_ipi_one() is
> important for PV spinlock kick.
> 
> I was also wondering if it would make sense to switch to using regular
> APIC IPI send for CPU > 64 case but no, it is twice as expesive (12650 CPU
> cycles for __send_ipi_mask_ex() call, 26000 for orig_apic.send_IPI(cpu,
> vector)).
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> Changes since v2:
>  - Check VP number instead of CPU number against >= 64 [Michael]
>  - Check for VP_INVAL
> ---
>  arch/x86/hyperv/hv_apic.c           | 16 +++++++++++++---
>  arch/x86/include/asm/trace/hyperv.h | 15 +++++++++++++++
>  2 files changed, 28 insertions(+), 3 deletions(-)

Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>