Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Rain Wang <Rain_Wang@Jabil.com>
To:     Jean Delvare <jdelvare@suse.de>
CC:     Guenter Roeck <linux@roeck-us.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH] lm75: add lm75b detection
Thread-Topic: [PATCH] lm75: add lm75b detection
Thread-Index: AQHVjYQRSTbeqfkrsEiXG4VEtvamlQ==
Date:   Mon, 28 Oct 2019 11:37:24 +0000
Message-ID: <20191028113717.GB10006@rainw-fedora28-jabil.corp.jabil.org>
Reply-To: Rain Wang <Rain_Wang@Jabil.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 46c077de-e0e8-41b7-1e4a-08d75b9b33d3
x-ms-traffictypediagnostic: MN2PR02MB6224:
x-microsoft-antispam-prvs: <MN2PR02MB622499313117ECCB045FBE678D660@MN2PR02MB6224.namprd02.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0204F0BDE2
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(189003)(199004)(52314003)(52116002)(102836004)(14454004)(6916009)(3450700001)(33656002)(8676002)(71190400001)(71200400001)(81166006)(6506007)(1076003)(26005)(386003)(2906002)(6512007)(229853002)(8936002)(316002)(81156014)(486006)(9686003)(4326008)(6246003)(6436002)(256004)(14444005)(6486002)(99286004)(66446008)(5660300002)(86362001)(66556008)(478600001)(66476007)(80792005)(25786009)(66946007)(64756008)(7736002)(186003)(103136001)(54906003)(305945005)(476003)(43066004)(3846002)(6116002)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR02MB6224;H:MN2PR02MB6703.namprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: Jabil.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VpAd2diEHNHbOZQA9W/wRj1wo0uoizmt8QPiDBsen9bsXLer67HQhDT/vaS1ibFtOfUc7UkQSiOfWe5mwQNDG7Xu/0bMsx76tLFkWLovsQLMzncJTlvX/4P86MUZs5cSVke/SnjshfcLGE7ae4OUaQ5PdA8VrQGtaL7a+0z+EExklJfDcBj8z8sWpFalt0kFaxc+GOvQIFTrBdbchrZOSrbi6PrvqXeuHe9RX3HCJ5O5jojxjxIGGio7otgUaNMsVkpF3yldFEE58ZnbWq5Ra5Ets3PhDToUyENKACtXeAFIfdDo+tw0cowVIBfXvj/89sR4aQDbONvr+4LMJAUxnNuTava5KDKyl6tDHZyGLEPd1yC8Wv0GJW5e68d+tjqz1pT4WODlHjCRenE7ZXd2utrhZnv8Lzq285Ymac+tDk0UzgxtAov3sVGJLqpv03Ly
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AB288F74DE738940A02A1E6305AFB442@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: jabil.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46c077de-e0e8-41b7-1e4a-08d75b9b33d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2019 11:37:24.5837
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bc876b21-f134-4c12-a265-8ed26b7f0f3b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uLWMU+iLY1nUpTQaDpyXWwIgdUlVQu7tLoSx9+6UoS+t6bCYCox4pfDONipHLPXPPUNVvBLVR6tgn9pSofnNfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6224
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Please send hwmon-related patches to the linux-hwmon list.

Sure, will do in future.

> I'm positively certain I don't want this. Ideally there should be no
> detection at all for device without ID registers. The only reason there
> are some occurrences of that is because there were no way to explicitly
> instantiate I2C devices back then, and we have left the detection in
> place to avoid perceived regressions. But today there are plenty of
> ways to explicitly instantiate your I2C devices so there are no excuses
> for more crappy detect functions. Ideally we would even get rid of
> existing ones at some point in the future.

I understand the concern, but there could be scenarios device tree doesn't
apply while some dynamic detection is still a valid requirement, not sure
maybe I'm wrong from beginning.

> This patch is bad anyway as it only changes the device name without
> implementing proper support for the LM75B.

This is only change we made just have our Intel C1516 board with LM75B sens=
or
working anyway, while majority common features of LM75 just work.

Regards
Rain