Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3488180ybg; Mon, 28 Oct 2019 13:43:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEUHPQDytt9CWdpRo3Vu6Oq1abgq1DaKmkh4zLxwAgQ+y12htU2KX+FbHkJXofurNUeIZg X-Received: by 2002:a17:906:e296:: with SMTP id gg22mr19092762ejb.211.1572295426259; Mon, 28 Oct 2019 13:43:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572295426; cv=none; d=google.com; s=arc-20160816; b=dERpJKbpS1YAwR1KFGI5R7lXGTDcoLXS/rI7GKoGxrAgnDJSiW2TLi4IpDi2KSSc3Q sqvWVotaZPoC+0LZjJxDWVo0/PKFxN1sRXYyYX6WMDSQOWefkNjDFgHfquhL1qxxFcja 2r3OssdYrPFa+NrrLKAlZvEyMCnbbEarfSK40VTW/LfUKgVAbDuKx4SmJpYG1L2UN4F7 ZuUbaqmGb7J3MICOSpBIi1dEeYmmU3ZHT9FcmI1pGcl17hvdTQtyPSTUydVHU3czXE5t R7Kfh5HlLedBIrXvOurMC8HQ+6hmNHS2KyKomAtEQ4HIzp3/upruj9lMnCrTcr9Fnls8 nhUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=4YGW1L95W7Uv8nRUZxgU6YBJTbDiZCUVVlXEe5KDtno=; b=1EjYznU71h27IRnkUSqSoXgqoxoRhkUMPTjN63AVzU4g/SqGKzIaBP2xRkGSSSqlPr NCdWJCUq5jBZiZE4ozc6JmsTDXwgArWMSm6mg0p34fGZdvylNCYJNdMVORg/o4gbo6MJ JP/6ZUAyav6RMQqNT69rMYSppW2+m2eX52QxYl4GKOsziwt7Xkh0vtsSeWvrkUuHRc0X xmiZT7R7EvTqdd4mCplpSkfqg1pvAOpK/Uv/JaXD7XFuRka5sXoYalEsB/ac/BgBGJ1x t72QK6vUcid13kfaxGyqD3UGV/vP958F+hz13QSfS/pDe1XTm9oyOPFGXfpLB3+RX8U4 yGvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd8si7232811ejb.194.2019.10.28.13.43.22; Mon, 28 Oct 2019 13:43:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389624AbfJ1Nlf (ORCPT + 99 others); Mon, 28 Oct 2019 09:41:35 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:39117 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729328AbfJ1Nlf (ORCPT ); Mon, 28 Oct 2019 09:41:35 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iP5H3-0006uL-5A; Mon, 28 Oct 2019 14:41:33 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iP5H1-0005La-MM; Mon, 28 Oct 2019 14:41:31 +0100 Date: Mon, 28 Oct 2019 14:41:31 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Biwen Li Cc: Oleksij Rempel , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "wsa@the-dreams.de" , Leo Li , Aisheng Dong , Clark Wang , Xiaobo Xie , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , Jiafei Pan , "linux-arm-kernel@lists.infradead.org" , Laurentiu Tudor Subject: Re: [EXT] Re: [RESEND v2] i2c: imx: support slave mode for imx I2C driver Message-ID: <20191028134131.5pq2vaqojx4gpfth@pengutronix.de> References: <20191009101802.19309-1-biwen.li@nxp.com> <113865e9-e846-1079-6f58-7fddb245398c@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Oct 25, 2019 at 04:02:11AM +0000, Biwen Li wrote: > > I'm trying to test you patch on i.MX6S RIoTBoard. So far I fail to get it > > working with following setup: > > 1. register i2c-gpio > > 2. connect i2c-gpio SCL to i2c-imx SCL pin and i2c-gpio SDA to i2c-imx SDA > > pin 3. run this command to register i2c slave eeprom on i2c-imx: > > echo slave-24c02 0x1064 > /sys/bus/i2c/devices/i2c-3/new_device > > 4. run "i2cdetect 4" on i2c-gpio to detect eeprom on i2c-imx slave. > > > > So far, nothing was detected and even irq counter of i2c-imx didn't > > increased. > > > > Do I'm missing some thing? Please, help me to test you patch. > You not miss anything, but the i2c-gpio driver from upstream is not > workable on imx(I have tested the i2c-gpio driver with oscilloscope > on imx8mm-evk, I cannot get any signal from the i2c-gpio bus). In general the GPIOs are known to work, so I wonder what the problem is. If it relies on being able to read the state of an output it might help to set the SION bit on the related pins. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |