Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3521460ybg; Mon, 28 Oct 2019 14:16:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVeASE5kAFuLrImDKh2adW45tzyG67PqonOB1CSz6LK48keP2fchEnqbH34/lFooQjm04O X-Received: by 2002:a50:9254:: with SMTP id j20mr22805225eda.0.1572297384815; Mon, 28 Oct 2019 14:16:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572297384; cv=none; d=google.com; s=arc-20160816; b=LYQjoXfUjBvu86ZLUgT3T8BE9SQ4G0HWoqJ29Ztuz5THUYkG4TmNtjjQE1ifqdzWVw HONGZ3XxXKKGviNGOpHsIJc+5+Dol5256uCOrjQsJDCUwLXAF2SbVrpDH1EfVVFe60mM o41TegeVTqg3YF+2SQ6GrMyXhG+3ymDF+nJOOl6MbBEq0R0yEInT9Dmn6H3CFg6fBS6D T0LsgUXOsEWzAzxU4RrjZhJkVgdBPcO2j/nxR9xlS7sDb4J1hzb36thsrTiVJqIhvyDP 7G+8moFVWbYLCebT1wkRN/hhuTNmB3mytTv5NQnXMKWakCyWXtuNCSG98Y2GTSASTQgd 6TFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Il8VW8OMpcWtzWFwYHuR8kPIHmlq4kOBUG1WYC/y+bs=; b=YCN5mAwkR9FOlNWbxx1X1oZk6kYCsl3YIWrUAMVQrhNV+HygStGVXpHS1/2v8n6qWv gGj6065uNCgoUAoKy0U9TTZYZwc0GDUlEzj4t3IzyrJgOwTCSbDeLt3HDP+Cl72Nd5QY HWTZWIuocHPsoLwl1wg/MmfbVwu77G6qeOF8uFvKMzV/g5YmS2mjWr9j8hXo446ljL6G Rc4uPVfhLoCXQvs6a9SilohNmrHTjWGUieSdVDX3zB9StVjGqsRZcKOSLEJl7Qo2Bk8b u0Rd7WqTuUXw5SqMer7Xp1W+s6VSIQxo1jXXZhhUCmZUy0fF5cjwYzyL1QhCbu3xcGwX Yy5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vYVakxo+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9si7050488ejc.244.2019.10.28.14.16.01; Mon, 28 Oct 2019 14:16:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vYVakxo+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732149AbfJ1QR6 (ORCPT + 99 others); Mon, 28 Oct 2019 12:17:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:40456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729798AbfJ1QR6 (ORCPT ); Mon, 28 Oct 2019 12:17:58 -0400 Received: from localhost (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B91D20873; Mon, 28 Oct 2019 16:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572279477; bh=FTD8UTLcgLaGI9mBwbZAP+9OgidQNFDpWRVoGM6yAsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vYVakxo+EsEPXom6s7IRdjYw6W3NFGAH7Y7//mxwDU3HPAFW+Jnto7kCMWhEyEvO6 LHZmPyg6HHoxkuzfFtugztwoTgFzKOPMXHUyt9x/pfOb+LPE0kmgHvpzQbZXsXpovg NW04GO4Z9N9trCQp/m88MrVuVd15bTfVKQ0re8TA= Date: Mon, 28 Oct 2019 12:17:54 -0400 From: Sasha Levin To: Olaf Hering Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "open list:Hyper-V CORE AND DRIVERS" , open list Subject: Re: [PATCH v1] tools/hv: async name resolution in kvp_daemon Message-ID: <20191028161754.GF1554@sasha-vm> References: <20191024144943.26199-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191024144943.26199-1-olaf@aepfle.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 24, 2019 at 04:49:43PM +0200, Olaf Hering wrote: >The hostname is resolved just once since commit 58125210ab3b ("Tools: >hv: cache FQDN in kvp_daemon to avoid timeouts") to make sure the VM >responds within the timeout limits to requests from the host. > >If for some reason getaddrinfo fails, the string returned by the >"FullyQualifiedDomainName" request contains some error string, which is >then used by tools on the host side. > >Adjust the code to resolve the current hostname in a separate thread. >This thread loops until getaddrinfo returns success. During this time >all "FullyQualifiedDomainName" requests will be answered with an empty >string. > >Signed-off-by: Olaf Hering Thank for the patch Olaf. However, it seems to break build for me: /usr/bin/ld: hv_kvp_daemon-in.o: in function `kvp_obtain_domain_name': /home/sasha/linux/tools/hv/hv_kvp_daemon.c:1372: undefined reference to `pthread_create' /usr/bin/ld: /home/sasha/linux/tools/hv/hv_kvp_daemon.c:1377: undefined reference to `pthread_detach' collect2: error: ld returned 1 exit status -- Thanks, Sasha