Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3650398ybg; Mon, 28 Oct 2019 16:36:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFJIeSLcQoBgYyfJMpRIKy3urX3aLwYzXQ1pQe1F8ARYZ+JGIUs0oz685t5S5XlMrHvyEu X-Received: by 2002:a50:e609:: with SMTP id y9mr20582237edm.55.1572305778173; Mon, 28 Oct 2019 16:36:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572305778; cv=none; d=google.com; s=arc-20160816; b=tVqmcr51p9r5+cijWgB1kWHA2u6LycZ7AfPlLPNv7H4KCTHddhuCZJNE+WADcLQ4K3 +GDH4LAHFRzeWobtQpchG2tLtKD9lzhKm9/4P9pxkM0t+Zvkpqgb3FZf9Cws72YR0fho /y8nJACh50UVGTtpJ3N0+yIq/YF6vxQ/ZFusv//RfiDomRWUiMDwrfea+IZyq4fuStFb 99xaUOJJaVg+OhYMvPo12OrgnS6o8VrcGz/EyXiVWAg6Uu508MDe5fZvizdM8GNzlGIa xGMSOrXHvpSypM0LDiVbTT/HZTk1M4TeuB4zIzHiFsBSa3BfTvoeBC38p6EoOeWfLPCo VPuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=I72XGxkEoDy+Tdj03u0pqOtzQc0XNaDPYtMjr+LJdRE=; b=qI8ztHD8a1fyJ8kJgbU7+A8d54amDfd6kQVu3EK72gXyTQ8Bd0b7VINK/h+JOYDDm1 J3r/HUbG6tauZrTE4ipb2kN/C/UMCDYC0h77PSiZfQPHtHnhmT3U6+D0ptGk/723BdBW sq7K1KntxIY53yIojkeA2/2vKRFP+0MUT9lo1LFGmHwtUe7SBkX4q+8lEY8u5ROwy8MV 7TtF4NAbcJt+YRAQeizi5gYb2sUoFW5URUDr7WJef3aoJunO1mbqwLjI10M3Vqy9pwmE 91LaHf/O6izqCEQuYnOVIS88uj76bnEx4qayBjrT6rF1Tyde7ya4Fp5XRI9zCXVukHuh EiYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gl26si459587ejb.331.2019.10.28.16.35.55; Mon, 28 Oct 2019 16:36:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732571AbfJ1VsC (ORCPT + 99 others); Mon, 28 Oct 2019 17:48:02 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:22441 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730592AbfJ1VsC (ORCPT ); Mon, 28 Oct 2019 17:48:02 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K9o0210015TFNlm039o0FH; Mon, 28 Oct 2019 22:48:00 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 22:48:00 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , alsa-devel@alsa-project.org Subject: Re: [PATCH 31/46] ASoC: pxa: ac97: use normal MMIO accessors References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-31-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 22:47:59 +0100 In-Reply-To: <20191018154201.1276638-31-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:46 +0200") Message-ID: <87lft4k0ds.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > To avoid dereferencing hardwired constant pointers from a global header > file, change the driver to use devm_platform_ioremap_resource for getting > an __iomem pointer, and then using readl/writel on that. > > Each pointer dereference gets changed by a search&replace, which leads > to a few overlong lines, but seems less risky than trying to clean up > the code at the same time. > > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert