Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Oct 2019 22:56:15 +0100
From:   Sebastian Reichel <sre@kernel.org>
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: cpcap-charger: Make
 cpcap_charger_voltage_to_regval static
Message-ID: <20191028215615.3efezzsc5gji722q@earth.universe>
References: <1571672407-58950-1-git-send-email-zhongjiang@huawei.com>
 <5DB71465.6050203@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nnsnvouks6a7nqnj"
Content-Disposition: inline
In-Reply-To: <5DB71465.6050203@huawei.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--nnsnvouks6a7nqnj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

https://lkml.org/lkml/2019/10/21/1018

That's e3da2ce04e12 to be specific.

-- Sebastian

On Tue, Oct 29, 2019 at 12:16:37AM +0800, zhong jiang wrote:
> ping.
>=20
> On 2019/10/21 23:40, zhong jiang wrote:
> > The GCC complains the following case when compiling kernel.
> >
> > drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_char=
ger_voltage_to_regval' was not declared. Should it be static?
> >
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> >  drivers/power/supply/cpcap-charger.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/suppl=
y/cpcap-charger.c
> > index 40d96b8..c0d452e 100644
> > --- a/drivers/power/supply/cpcap-charger.c
> > +++ b/drivers/power/supply/cpcap-charger.c
> > @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap=
_charger_ddata *ddata,
> >  	dev_dbg(ddata->dev, "state: %s\n", status);
> >  }
> > =20
> > -int cpcap_charger_voltage_to_regval(int voltage)
> > +static int cpcap_charger_voltage_to_regval(int voltage)
> >  {
> >  	int offset;
> > =20
>=20
>=20

--nnsnvouks6a7nqnj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl23Y/wACgkQ2O7X88g7
+prsiA/8CFPmGfF8s7d5QI8hJ1R1KnjkOc5kHSIx954UNaHfA/gdjA3jy4oqjDDM
t6nIZUWphJerbqGPfOZIwOQdOhAmjTV5LAtRLkg+IVxEvF2jQXYMaM9Ip5Nke35a
pULPnkSeWARvMFZZYKnxG6OPe6AL8eqRaHBXRWC/Gd0XL5ndqW5SWgDeNOubmJtj
lRmJcVh8s5IB3FafOTlTGA5GQosqrxIa5fWrXL3d/bC0gE9WXa5BKw0XAgv9OSr2
dDJBpMemDCtQmXcmEN7LFg5OD4PUChdL2L60FOPpJnlpcktqNMUdUJ3S9dGuG9RZ
QmYnv2zyC9PRWf0pH0K6ovLsqQrIx0SQm9+PK6jSTyJH/KFuaeHCsdO17wq/BetW
VBZ00Bh+1hXovCQ3lwb6cIqh22hddY0KJiABOfd2kG6cw7tphLyYK8s4YQYYOBrh
GmHU2iLak+inpvB9IX/EtbCwWgahRnI2Hxp9LS15nxt4pyg1Pj+A1264IzPE6EMl
t43BGPt3MSjDIXlUDaR+MV3ibyCzwiq6j3tfihvNWcEiDQgdGSBANAvAXduo8po7
MtgkWlgBvnGSrfcdP60aKblFEqUXQUFCCzTx59j1h6Z6WUckHfZYN55BOsh9LkwW
VNAuWqJDP9iaCNz49ove8YjDuuCq6T5JH+jCPusa6Pg1obbvbYw=
=NLra
-----END PGP SIGNATURE-----

--nnsnvouks6a7nqnj--