Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Jarzmik <robert.jarzmik@free.fr>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: [PATCH 33/46] ARM: pxa: pcmcia: move smemc configuration back to arch
References: <20191018154052.1276506-1-arnd@arndb.de>
        <20191018154201.1276638-33-arnd@arndb.de>
Date:   Mon, 28 Oct 2019 22:57:43 +0100
In-Reply-To: <20191018154201.1276638-33-arnd@arndb.de> (Arnd Bergmann's
        message of "Fri, 18 Oct 2019 17:41:48 +0200")
Message-ID: <87d0egjzxk.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Arnd Bergmann <arnd@arndb.de> writes:

> Rather than poking at the smemc registers directly from the
> pcmcia/pxa2xx_base driver, move those bits into machine file
> to have a cleaner interface.
>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> -static int pxa2xx_pcmcia_set_mcxx(struct soc_pcmcia_socket *skt, unsigned int clk)
> +static int pxa2xx_pcmcia_set_timing(struct soc_pcmcia_socket *skt)
>  {
> +	unsigned long clk = clk_get_rate(skt->clk) / 1000;
>  	struct soc_pcmcia_timing timing;
>  	int sock = skt->nr;
>  
>  	soc_common_pcmcia_get_timing(skt, &timing);
>  
> -	pxa2xx_pcmcia_set_mcmem(sock, timing.mem, clk);
> -	pxa2xx_pcmcia_set_mcatt(sock, timing.attr, clk);
> -	pxa2xx_pcmcia_set_mcio(sock, timing.io, clk);
> +	pxa_smemc_set_pcmcia_timing(sock,
> +		pxa2xx_pcmcia_mcmem(sock, timing.mem, clk),
> +		pxa2xx_pcmcia_mcatt(sock, timing.attr, clk),
> +		pxa2xx_pcmcia_mcio(sock, timing.io, clk));
>  
>  	return 0;
>  }
>  
> -static int pxa2xx_pcmcia_set_timing(struct soc_pcmcia_socket *skt)
> -{
> -	unsigned long clk = clk_get_rate(skt->clk);
> -	return pxa2xx_pcmcia_set_mcxx(skt, clk / 10000);
That curious, because you divide here by 10^4, while in the old
pxa2xx_pcmcia_set_mcxx() that was 10^3 ... is that a fix I don't see ?

Cheers.

--
Robert