Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3665495ybg; Mon, 28 Oct 2019 16:54:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqzO4jhi5HIToETdcQdW7Q/DkVRnhw98S8Ooi1WKIUFp2yoGy0f7gM7BkbYM7ZrjSBSl1Vmo X-Received: by 2002:a50:895c:: with SMTP id f28mr21774795edf.125.1572306894702; Mon, 28 Oct 2019 16:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572306894; cv=none; d=google.com; s=arc-20160816; b=SDm0rniN1sss7ZhfvF5XX55fucMsK9qRFY+bQVORFC0iWrxBKSDNPy48yw8xHcQ55R 02MD/7u3Fgv7QfuJwZPaYBVfoOQMsar+DE4Xow6N2HgmYmYlvs9RlHLX7sslBnpPBAj9 LrsydwS7tTBZ9PtQqc0+2ElNGXcDDpVMYcUziZfGvDDjxHde81f/+Ol3WKJrxvXFhnKw KlLYC7sZQJbVhyAU+Oh+00OVcSaaDkzOdkDDLmicI4BCaBtY+tsfGnwMXNfuYpRMdOqe 0fMl/QbR/yYd8Rr8xK9f1cK+4XYBHVXeTDkGfOUMb4OFRotZ1DqeK4uxdnXjpXHb275p swYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=PCsSu8gYt4u4EevBVmSGwMGFm7zMVFUZYG+52Kabl6w=; b=CpxMgbSezMZLZeaVBDUaOG/bp2D1ITR571Sqd6mYUE5n1eChMOeZAaGq8IC0bHeJco ifQJzpPBw9tD+HoS6RcXRGgCBjqHfRoI23Amujc0LvfiHrVuQvmOkrxCdwWHbpmlsPyK h3FUnCGN9P76kX3inYIqpkGN43fuCjRljibgpEHZ0cOMCQI822Hiq0Mg1IzYnndZJueX tVA6bfZivB4aQqJKJR4m0zF/MLzzRJdMDj7WHLG1j5SSe0g1eNVqghWBqTCEWv7zCU23 FBOa5/lvSdtmKgBc/7p93Z3DDfaeuVicQliisY/5BIAH3weCLq8BiRVofMU6XyUyw1p8 lszw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hezMheFb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si9188224eda.278.2019.10.28.16.54.31; Mon, 28 Oct 2019 16:54:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hezMheFb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730206AbfJ1X0K (ORCPT + 99 others); Mon, 28 Oct 2019 19:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:41474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfJ1X0K (ORCPT ); Mon, 28 Oct 2019 19:26:10 -0400 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D497321835; Mon, 28 Oct 2019 23:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572305169; bh=q0OTmR1wgzTZD6EaP5k/W/AbGqmVSJjg13ZftmTiSZE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hezMheFbDN23JCAY51dksxmJGn0f0gJFzlQ8PYwJy4eQmyUpqFhnzr863IXmnm6ZY kcB9f8rfz07kpiqgLMVBNNbp+poxaJxOovMwaRP++vNhaK++Mkx/XqdgjR5SO05Klx iC8UVKO2J1iWAez6QSVAdSSs6K5+czLaTrL27/J4= Received: by mail-qt1-f179.google.com with SMTP id x14so7020839qtq.3; Mon, 28 Oct 2019 16:26:08 -0700 (PDT) X-Gm-Message-State: APjAAAXA12PoJAjIQharsHtY33lEuNdXU5kQnmcVaGF/9Rk2mAYevXvN bsEa+1uMlI61Yl2eoqp1wRj36gmF2P68X46kvA== X-Received: by 2002:aed:2706:: with SMTP id n6mr523854qtd.224.1572305168028; Mon, 28 Oct 2019 16:26:08 -0700 (PDT) MIME-Version: 1.0 References: <20190912213257.24147-1-andreas@kemnade.info> <20190912213257.24147-2-andreas@kemnade.info> In-Reply-To: <20190912213257.24147-2-andreas@kemnade.info> From: Rob Herring Date: Mon, 28 Oct 2019 18:25:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios To: Andreas Kemnade Cc: Lee Jones , Daniel Thompson , Jingoo Han , Jacek Anaszewski , Pavel Machek , Dan Murphy , Mark Rutland , Bartlomiej Zolnierkiewicz , dri-devel , Linux LED Subsystem , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 12, 2019 at 4:33 PM Andreas Kemnade wrote: > > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade > Acked-by: Daniel Thompson This breaking linux-next now... > --- > changes in v2: added example > changes in v3: added Acked-by > changes in v4: moved enable-gpios to the right position > in the example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..c8470628fe02 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg > @@ -96,6 +100,7 @@ examples: > led-controller@38 { > compatible = "ti,lm3630a"; > reg = <0x38>; > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; Error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dts:24.46-47 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml] Error 1 scripts/Makefile.lib:314: recipe for target 'Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml' failed You need the include for the define. Rob