Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3668427ybg; Mon, 28 Oct 2019 16:58:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzKhBgBH7s9gIytoEsqUiDA/c0I7c3spjfIlpRfTMRCanpPv32NlJQOfondkzHrz2vkAhj X-Received: by 2002:a17:906:31c7:: with SMTP id f7mr539729ejf.206.1572307126433; Mon, 28 Oct 2019 16:58:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572307126; cv=none; d=google.com; s=arc-20160816; b=R9Plxxc33jIfKvmIRB0hrkYjtQXlqeewOEVhu/monyERotyQqeMi8hOO7XQgN8Z963 +GbxOmGglsnCxTBVYD4BttdNoQGA7C2nYzNBEIriYd3Jz0Hwvgzj/iTrJgbtfN+4+jlL Jhv+ZxnU77XX/fMKvjOHr/b7dFN5V+LBg3W0dOC0/3+oVp9jhXEniDRJdemD0tdU+pMs UWq4yxbYlrJutGzLvXXKE/Q1HLnEF+8/OsIUFiZAXz8Zi8gCDA6VxEj2luEJUMwmZp/M DmV5hhxO41qUlEyqHg6tXkC/CSBj/KrnQO82KHdlThqkSV7jDdOkiS3Qfm74Qooi7Dqk RrlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=pqkGQqPtMm90ppR/P2uelWNerJs/mxBlukZF3/5TyPw=; b=PSGwoUqs10BuHL787mvcims83TIJOQzgwpzu5lkQCSWIV+9B8sie0OgdQHTkXuIaUe J6HLO47VnscUCRpYuD0gZHeUhb37sU2B1g8y8wi1RtsuWa8x3uJPRRr366ovrJTpZyLE C75lonucuu1MSQnoWs1tPfy1rE0I7VnvfMlkJMRDBFCsmmaqDdYxJV/iVzNQNazqv921 967+zxrqMzHeLkd+uKjRFl7eS2M3yt6EdSMTzfsmXhnKwjc6TBSMTcafImFRqrAnXqqY pVeBL0o25X9IxEEz85g0ZhRQI6hySxEhBYN9erKFK/Rd/MGKHc8GJZCAYujJUdnyC/Q+ PtXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y61si9288484ede.24.2019.10.28.16.58.23; Mon, 28 Oct 2019 16:58:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732442AbfJ1Xfo (ORCPT + 99 others); Mon, 28 Oct 2019 19:35:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46666 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731587AbfJ1Xfn (ORCPT ); Mon, 28 Oct 2019 19:35:43 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C7AFD14BEC4E3; Mon, 28 Oct 2019 16:35:42 -0700 (PDT) Date: Mon, 28 Oct 2019 16:35:42 -0700 (PDT) Message-Id: <20191028.163542.651907517920532587.davem@davemloft.net> To: dwagner@suse.de Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, woojung.huh@microchip.com, maz@kernel.org, andrew@lunn.ch, wahrenst@gmx.net, Jisheng.Zhang@synaptics.com, bigeasy@linutronix.de, tglx@linutronix.de Subject: Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle_irq() From: David Miller In-Reply-To: <20191025080413.22665-1-dwagner@suse.de> References: <20191025080413.22665-1-dwagner@suse.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Oct 2019 16:35:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Wagner Date: Fri, 25 Oct 2019 10:04:13 +0200 > lan78xx_status() will run with interrupts enabled due to the change in > ed194d136769 ("usb: core: remove local_irq_save() around ->complete() > handler"). generic_handle_irq() expects to be run with IRQs disabled. ... > Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler") ... > Signed-off-by: Daniel Wagner Applied and queued up for -stable, thanks Daniel.