Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3817477ybg; Mon, 28 Oct 2019 20:14:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9v9+tJhjmqxQjhYYiWYWIC/xPbgL2OF7K0Mk0PNYXNphIbpTNeXVsS0jmpQIohX/Hu8my X-Received: by 2002:a50:fa42:: with SMTP id c2mr23353726edq.112.1572318856422; Mon, 28 Oct 2019 20:14:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572318856; cv=none; d=google.com; s=arc-20160816; b=aC0MAwj1IOxPYQSgwtQ1KT7VFE5/Cy4eXNWT0JuKgNwJr9iIVcpHhKrdXHY2nZDNq7 q51eShSYivtq67eNlGEyyMOzmVTCz76slyuE9Mjr5NcMsZhbB4uNjsMYxhJuFrGTzLNp kmxCKY/OSQr2F7IF8E3ZNMeFWfZehSoDyHogjcCEWaaRmF3R4Q1ey7QFyWBcbsU0r2Ux HJnzs+scBsNAZsFrnlMJ+mcqdltrqu8ekcJF3xO1Tm30xTCpuH1qJQuw5jK4plHaAbir rmTDUh72x7ONGvJITOIsmBzTd8R0Q/DqmMX4RebKtfHSCCmpAZf6k8we/MLkvwdbsbHw EYRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DexiSniE9qfTheizv+7sPjyk9GhVZ3O8j++U/oGH3WM=; b=LsmTLTNC42vhFthhbZ5CU/G6hM7B8yXG3SL1y6qQG1VaNJERg9mC8TNLHjEwPlMK7B mUhhrKwldeUwMF1SqSKDUJdFamxuWVoQ0k1/pPxOwiarcc9FtWZE4nKaCfS0wYuVL55n 3rBwllKxvVdcYM32+Jc3yG74XSE8gRG9UaFtWQcvQFsV9LErsavrW/3HDAbnr8vnokTD PJ+o+DR8lG2zKVZ7nSCBHH7a5sq9tQNCe1sNU5O+AJm0u/1y7xOEmDbtC8LzHdKTSVsG Qx5rU2oBi0MKECQlz4p/0WfJ30oBnm0AjtNyMRoWA28ZH3OV3VmCqMf1IcSKtMQ4STQc jgPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f51si8899584edb.421.2019.10.28.20.13.52; Mon, 28 Oct 2019 20:14:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729889AbfJ1PWe (ORCPT + 99 others); Mon, 28 Oct 2019 11:22:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:51958 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726553AbfJ1PWe (ORCPT ); Mon, 28 Oct 2019 11:22:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B320CB20E; Mon, 28 Oct 2019 15:22:32 +0000 (UTC) Date: Mon, 28 Oct 2019 08:21:08 -0700 From: Davidlohr Bueso To: Stefan Wahren Cc: eric@anholt.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: vc04_services: replace g_free_fragments_mutex with spinlock Message-ID: <20191028152108.bjliafudxn3llysv@linux-p48b> References: <20191027221530.12080-1-dave@stgolabs.net> <576df522-f012-9dd1-9dcc-b7e444e82ac6@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <576df522-f012-9dd1-9dcc-b7e444e82ac6@gmx.net> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Oct 2019, Stefan Wahren wrote: >Hi Davidlohr, > >Am 27.10.19 um 23:15 schrieb Davidlohr Bueso: >> There seems no need to be using a semaphore, or a sleeping lock >> in the first place: critical region is extremely short, does not >> call into any blocking calls and furthermore lock and unlocking >> operations occur in the same context. >> >> Get rid of another semaphore user by replacing it with a spinlock. >> >> Signed-off-by: Davidlohr Bueso >> --- >> This is in an effort to further reduce semaphore users in the kernel. >> >thanks for this. Could please also send this to devel@driverdev.osuosl.org? Ccing. > >I only need to know, has this been tested on the Raspberry Pi? No testing has been done, I have no hardware to test this. Thanks, Davidlohr