Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191026214732.17725-1-linus.walleij@linaro.org> <20191028155457.5uae2crf3ygvn3qn@localhost>
In-Reply-To: <20191028155457.5uae2crf3ygvn3qn@localhost>
From:   Olof Johansson <olof@lixom.net>
Date:   Mon, 28 Oct 2019 11:00:45 -0700
Message-ID: <CAOesGMhR=CXEeGdULrfAM9FUG7nhPWwUi=Epom_hQdML8On6uw@mail.gmail.com>
Subject: Re: [PATCH v3] mfd: db8500-prcmu: Support U8420-sysclk firmware
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ARM-SoC Maintainers <arm@kernel.org>,
        Stephan Gerhold <stephan@gerhold.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 28, 2019 at 9:00 AM Olof Johansson <olof@lixom.net> wrote:
>
> On Sat, Oct 26, 2019 at 11:47:32PM +0200, Linus Walleij wrote:
> > There is a distinct version of the Ux500 U8420 variant
> > with "sysclk", as can be seen from the vendor code that
> > didn't make it upstream, this firmware lacks the
> > ULPPLL (ultra-low power phase locked loop) which in
> > effect means that the timer clock is instead wired to
> > the 32768 Hz always-on clock.
> >
> > This has some repercussions when enabling the timer
> > clock as the code as it stands will disable the timer
> > clock on these platforms (lacking the so-called
> > "doze mode") and obtaining the wrong rate of the timer
> > clock.
> >
> > The timer frequency is of course needed very early in
> > the boot, and as a consequence, we need to shuffle
> > around the early PRCMU init code: whereas in the past
> > we did not need to look up the PRCMU firmware version
> > in the early init, but now we need to know the version
> > before the core system timers are registered so we
> > restructure the platform callbacks to the PRCMU so as
> > not to take any arguments and instead look up the
> > resources it needs directly from the device tree
> > when initializing.
> >
> > As we do not yet support any platforms using this
> > firmware it is not a regression, but as PostmarketOS
> > is starting to support products with this firmware we
> > need to fix this up.
> >
> > The low rate of 32kHz also makes the MTU timer unsuitable
> > as delay timer but this needs to be fixed in a separate
> > patch.
> >
> > Cc: arm@kernel.org
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Stephan Gerhold <stephan@gerhold.net>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
>
> Fine with me to go through MTD, so:

s/MTD/MFD/g

>
> Acked-by: Olof Johansson <olof@lixom.net>
>
>
> -Olof