Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3978079ybg; Mon, 28 Oct 2019 23:49:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNaMWAEIKWYEunMAo16BGCGGZCQgVXrh2zZFL0VrLPYw4sS6pTafnK9zbcDCWCJ2TmHLu1 X-Received: by 2002:a05:6402:75a:: with SMTP id p26mr12478629edy.221.1572331785346; Mon, 28 Oct 2019 23:49:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572331785; cv=none; d=google.com; s=arc-20160816; b=kPlFoBwQjByQ+ajfZJdiEeEoUK8Y++X1C1hmNMYDmWfnlr7FZMGO+JDwBlnuyGriMX vcDMAOOxszAOXUNEfXbMz8+upBk6MtxVm8gmvZRcPPzJoGv1xEMpDy/Mvn2QbJ0cK9UF akDqnMUuxcOAU9C1eAQryjnT0uO/K8x0CWL15dnRA5FadP/Ykt7Ef5fJts+Nm5dFjrrv aJYnp/5ZIttH0+ZwWwfOB0DIp8c2cIDi+CQqDiIo07xvqhsnNLG5CRWD9XzdEgjxoV2z 9/RFzXsH+7WtD3VLjtFhSvUnU7Ed5VR8MbIS2TB5+q1czEm2ty2u5G2tWh6IjR25aAJO 0hqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=iqi9O5aOhgHeg8hK22OMx57FP8KzGE/okSQXv7E6n5FYEj1vwmPAu9CNeCjMtEJtYR 0VInI8yEv3fyLRB0pHdRK+UXKnPLXGLZi1zCBvgJipWbsmxUEQ+dlxfmpsmY9t40QmH/ ZtUTdKcK9el+QcutfjKpYOmwNNcdMhrBnR00WQXD7uDJR3odBgXmyVgPj5Rh+koIYGbB cD29LM+lYUzxbz/PgQUjQYPKg+zP83d6YQjWXy5xgDjERzta0xOXlXk8wq4QS94n5tVZ GhEohbK6ckGOJXVccpczSR+fdvj4xCjDF41omFg2tyDBxvWfg3AxXAY5Jc1QHABiUZHu sqtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W9XRu8s6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hh12si7387405ejb.343.2019.10.28.23.49.22; Mon, 28 Oct 2019 23:49:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W9XRu8s6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbfJ1SjP (ORCPT + 99 others); Mon, 28 Oct 2019 14:39:15 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:34789 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbfJ1SjO (ORCPT ); Mon, 28 Oct 2019 14:39:14 -0400 Received: by mail-ot1-f65.google.com with SMTP id m19so7554811otp.1 for ; Mon, 28 Oct 2019 11:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=W9XRu8s6F/9TsFLHTcSQDb0Nv6pnIBlAVPHEIvO+0sRufsrPexDNntaTTDpMZkYUFo HPcrYBHpRf+ThMx5LF2vxZRrxrnvJBpc4Sqnihoe1cxFGg+lLl92BzCZvB5gPmy64oYx C1JVb5DYpmh6hT5M6smONPWDfCNxR+oiqBdKNQHXRCbonDeA8mQAlBm+G5c0IvbXpuED fhS+aVBYsHYn5SNgUF7cgHJNxZpIvtVB/Y6vQ+MwZhPqdFpje6OesPLagLI4Ug6Q/VKZ St6ztLOs3ojRqUZcTMIsSv2G7wbLOqTEMiKQ8LS2IyugyXUoJaGkFPbT/4mu9lCwKV9t 3T4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=J6KxMha9uGq2zdNwNJgp11X2mcvIRgjugDny+oj7Hae9DepV19wCWt908ntDmfE2Cx MLGu3so1crnbLWfRK5ptmUYG9nV16/hNq5Un715le1VSV0MkDxN7mUcmZ7jBg29/g95B L5sMXnMzhioCKyHO05kidNZ4D0+8b2x0rXOjO97D9gVaSa1HgmnyjkCovA0MQ7mZRyvx MyuogKZI/wYkiJj8xpvb504twUafLfDQWNE5WTywGfEe8Up2PLByEiQVcu/Oe3xKsc5R mOg19TSr776BFqthIGuNCH2GP7I29MwhzMwA5/ykKYZEO3oi5uTAvTc6DchCaLfsDxqJ 6sZQ== X-Gm-Message-State: APjAAAXlo7t36nnEwtjNZEnwYYC21mNyLY0DPVT1rvvMvduLUC/Li7dG AHrrCKOr+ewVpj6J669wlg9zYbpuiwhTIpXXGbgh0w== X-Received: by 2002:a9d:5a0b:: with SMTP id v11mr15027479oth.102.1572287953644; Mon, 28 Oct 2019 11:39:13 -0700 (PDT) MIME-Version: 1.0 References: <20191025234834.28214-1-john.stultz@linaro.org> <20191025234834.28214-2-john.stultz@linaro.org> <20191028074642.GB31867@infradead.org> In-Reply-To: <20191028074642.GB31867@infradead.org> From: John Stultz Date: Mon, 28 Oct 2019 11:39:03 -0700 Message-ID: Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module To: Christoph Hellwig Cc: lkml , Sandeep Patil , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , "Andrew F . Davis" , Andrew Morton , Yue Hu , Mike Rapoport , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 12:46 AM Christoph Hellwig wrote: > > On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > > struct cma *dma_contiguous_default_area; > > +EXPORT_SYMBOL(dma_contiguous_default_area); > > Please CC the dma maintainer. And no, you have no business using this. Sure thing. And I'll look again to see why I was needing to pull that one in to get it to build. > Even if you did, internals like this should always be EXPORT_SYMBOL_GPL. Certainly! My mistake here! Thanks for the feedback! -john