Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3978840ybg; Mon, 28 Oct 2019 23:50:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFGl50YGzQP8NvtQwZ9IF0Ab17c/UoP5BKrW++soMvvdpZMj3iWB11ZMS5ThDyID/w6iXH X-Received: by 2002:aa7:c954:: with SMTP id h20mr23684012edt.159.1572331836344; Mon, 28 Oct 2019 23:50:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572331836; cv=none; d=google.com; s=arc-20160816; b=Y+bYQI4UY+59VqJHr3xedbT8ryCR+xPY2h3RYyaa5sdSv4DYSOCN0AjhbTmMxEXZCx x/crgHGovx5gzaIlVnxcFjrJUirBx8ysMFZeOlF/pkSa4iToP15g7lADaQiyrvbHkFCz BceDysYZl65vHZvawKMCIbhsQka7kMLBWDLopgtdQeNn5uY8S/OgAetTVq1ye76Bw1gF nSrrhCA87oKTXUi9z+W5YlKADYb4H+VWofWe8IIatJIVvp0Lh4FmZdTmTli2pMHXgzme Xuok9flgs32pcgyRwSV7vmu0pRfbwFuBBRfXYns7XIusVFUPUdAWjs8uUSUN/eg+cWNW SC+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=o3RYmNY37sf+6DZhfgwoRw3pPEWurA9fTDFSIhMeWeU=; b=nZMuBHFhoL54XkeVf+MY3DCuue/xhtIdQ+JPytuuuFVI2YGNJlqosydqswhqbkewjU E83Mbvop/wrJcHYa5TWf1A8lnDwLQTtXrsggSB76IcYZ7GVaRFjxHYENbC0IGhkqsMi2 zknF5ckrbWbZnvXhoYejoORCoy5aJueChXNDRedv1fYmfWrIgWgwilbZRosVCTMLL0VA vyzmwbB+/crx6JJrJe1BuhAhoHexTC/kil0Bu1CkgmnTv5iAWk11PHa0Gyn7gRATCrdc yiAmm1BZRLpkrhaqRGC8r860YT3iy8lqlHm4sLEXhqoeblOWp8+hIZFqJ1nzcXMa1qHe 2dtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Oked80Gc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si7474300ejy.285.2019.10.28.23.50.12; Mon, 28 Oct 2019 23:50:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Oked80Gc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733070AbfJ1UVz (ORCPT + 99 others); Mon, 28 Oct 2019 16:21:55 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33821 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732924AbfJ1UVz (ORCPT ); Mon, 28 Oct 2019 16:21:55 -0400 Received: by mail-pg1-f194.google.com with SMTP id e4so3401693pgs.1; Mon, 28 Oct 2019 13:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=o3RYmNY37sf+6DZhfgwoRw3pPEWurA9fTDFSIhMeWeU=; b=Oked80GciIxQk1i/LR2xCPTKwGdtHhZxyUq2WWOVcfXgw0QLfGwTKSya0fFMyXHtjs 3AbRxlvW0j09zV7fmaXlpfIS1dMK7mr8MuFY2WEFdBy6HJ1RYD0hiloMysUpzCljhzrI ZKK/t6YfTEPwojUcpk4fuRj4+cfm641mdi3Wzs0y/OhMQkeolPTdwh2ClmdFDdAqMlX4 Bj3PZiqDHS9HORzfHhTa2ekYwbrQt805VoctgMyx6pb73lLWoHNXPPL+2RybnV7fwz/2 TlIfAphcosj9xIuxhpNKOsCqccOcPpzAqkkcCg5+5pBT4FV60WobxJZa4glF1yuLJF/w EzzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=o3RYmNY37sf+6DZhfgwoRw3pPEWurA9fTDFSIhMeWeU=; b=m2oUMBxzBeFs1A0o+ZuB3bNc14j/eWiA+gh/a1fXYoq+oiT1C8eEu+5arlS+6I5lN7 mI8eS4iUWXOV2RbU0cBUna+BQHYiWSVWzDsBm0EPAkyh6p2sUbiqvzZGcRLGTCfm7HY7 J75HSwI4qxWVgXm2cGFFiKuPCPMFKFPiIwxMAkfyGG4vryUsOUueEGmvI9FgFBHFey1h xLVEDLJWa5DYacQuioG+DRDKe/VclT3ozf984tLzfbzYp864nEwfjhinIVaZAore9242 QO4bvPVwouYufvPVKRLi4XrMlNOtofKK+4iHc/rb9Dp8uOTAeB+kgguPr31Dtb8lDTzB fAIQ== X-Gm-Message-State: APjAAAXCO5GiKn36HrVxcWNMBGBvc0xUJUvXL+JQ+ztMpr6WoJRy5Nfp h7r3Ut/jNwiDvXfgXcSZPnk= X-Received: by 2002:a17:90a:a00e:: with SMTP id q14mr1489905pjp.132.1572294114235; Mon, 28 Oct 2019 13:21:54 -0700 (PDT) Received: from saurav ([27.62.167.137]) by smtp.gmail.com with ESMTPSA id e198sm11908096pfh.83.2019.10.28.13.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 13:21:53 -0700 (PDT) Date: Tue, 29 Oct 2019 01:51:44 +0530 From: Saurav Girepunje To: jingoohan1@gmail.com, lorenzo.pieralisi@arm.com, andrew.murray@arm.com, bhelgaas@google.com, kgene@kernel.org, krzk@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com Subject: [PATCH] pci: controller: dwc: Remove dev_err use after platform_get_irq Message-ID: <20191028202144.GA29158@saurav> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Signed-off-by: Saurav Girepunje --- drivers/pci/controller/dwc/pci-exynos.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index 14a6ba4067fb..2293b346d96a 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -403,7 +403,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, pp->irq = platform_get_irq(pdev, 1); if (pp->irq < 0) { - dev_err(dev, "failed to get irq\n"); return pp->irq; } ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler, @@ -416,7 +415,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq(pdev, 0); if (pp->msi_irq < 0) { - dev_err(dev, "failed to get msi irq\n"); return pp->msi_irq; } } -- 2.20.1