Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3978901ybg; Mon, 28 Oct 2019 23:50:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmxundU4Sv379KVCg4ur1gNzxAd+OcNX40k430Zp62cCGB3srzZsUwtw3kqOpw/YNtkXra X-Received: by 2002:a05:6402:304e:: with SMTP id bu14mr20705529edb.89.1572331840152; Mon, 28 Oct 2019 23:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572331840; cv=none; d=google.com; s=arc-20160816; b=SxP+TiVgzMzqY0KFyxS6KLxdLKGW0ZDxAKjf7hNR2R8Q9BIdv9oREA+CWk9JUgXQOj b3/v0uCdylXLNma/u9Qzh8HOGEVx2dejrhBYvpRN5q7sQbSTRoe9m9TFnbSwLAQA/aR9 zxIZ5vvdd4wNp663doeBjiqyeEwCfnsyfeKKVsAGdsFob5+/ekJywIJTPXIXhvM3nYPM IBWf5gpmNFFd39GbFQjnFub+DNeZ/yr3lsMsSJXNpBKMtdC4ozQ6eabGTewuL0i4woX7 mcMmGDIE9dAGUVask4nY1mEaIjWBTL0b4vS4YYKiFFE1nLfamWpWfoYIkiFQm0wouI66 ml4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=WeECtJnzslq+3WsgfzFxA4T6kzwJDi2w9834CWvUQDQ=; b=hPp6Ydvu5wDSM40VPcalhFLnEwGbWitperzChGmDQjLxjcSD/kH7h54O9oailbCBnD buyjDNx1cIaS3uowh1BFg+KUMjC5Kef/gC4AAdUhB10BM95E0A+vjBRLgZWbk34slZTT 8ZspfmPQIUCsLHNVnmytXntp4RFd+fZXx6W7GSPAxxTxJSZFnwoQCJi9suuj8iYmDBSb GyPqaXQKaos12J78lHAl8v3FADvsR9fGrrSD1Za1nyGcwkXGNOy4BGxC7wxsvQYb/lFu fnj9abGVM6Eb3Om7hL7wl7T+eijvunYTo++34430hlkOF/NV1+W08PUKDlSZSJgQuJlp wASw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rPw09B5p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gw21si7919992ejb.202.2019.10.28.23.50.16; Mon, 28 Oct 2019 23:50:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rPw09B5p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733127AbfJ1U3y (ORCPT + 99 others); Mon, 28 Oct 2019 16:29:54 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38586 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727960AbfJ1U3y (ORCPT ); Mon, 28 Oct 2019 16:29:54 -0400 Received: by mail-pl1-f195.google.com with SMTP id w8so6243279plq.5 for ; Mon, 28 Oct 2019 13:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=WeECtJnzslq+3WsgfzFxA4T6kzwJDi2w9834CWvUQDQ=; b=rPw09B5peYfusomKmiOxxzTbeVm0asYJLc9fmGRItXzuM4PpftzeBc+1d5ljPwz6y5 GYwLs7z0lb1nXXX6kz+BqPjluz+bDq/WT+0f9W9PC0YwtJWllm4OTTBcZ57hNjQLYd6p 7Qn95QOroC3qyN8HTpcaHoB+1tOCvzTbNFmCLmDiM7vM2/zyKHxOZQt/u+aacMro/lOB pZJfwAPg49plLKAAC7oZhcQCjZUfpokZZ5H+pMurD2UtWuJZUBT+VjFPRlh8+qqdpGe7 a/sED/I4RvQ+2b3wfR7IhKx/T0SsLbo7ILPls68u6ORcvBCxFVm+5lcUIARZJ7ys5ll6 1U+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=WeECtJnzslq+3WsgfzFxA4T6kzwJDi2w9834CWvUQDQ=; b=GE+VdwU7tAiKwF3XjJxL5YoRRN7TJ9Tad5e3dEcSoBtfwLN5r3BEUYAjXTIon8+WBe 4M4Nplxq3ZkmiupxJdd8N+psYx71orfRQdsxGeZ3szcXB6fU02bNXFHggxbHB/e4qbKL Su4QltIU8/VACf9VbtYeZyAcJvGgYvzTpMcgwJ98z6K0rKcIf+xdAE9lcmNfjokaPcVb 4kvs2Rusne6uZLlvC1rXbC1hOFRr9t6yNcp+/sOlWATtbkdOdNey7E7jetnK4FNVzGIH PO2El2ieGeKmgY5HrZ5UR7fNESegt/vzD4jwdA1UB4yhZRG8pGua3iljUgW6by8vF6Ln kajA== X-Gm-Message-State: APjAAAXdXhsuY+wcXtDQg86ypHc9f2/sDYzECq/+ye2ID6bKRAuLki+i tgbTdX7ivWmILzWMpE2lDlc= X-Received: by 2002:a17:902:6bc4:: with SMTP id m4mr21103928plt.103.1572294592207; Mon, 28 Oct 2019 13:29:52 -0700 (PDT) Received: from saurav ([27.62.167.137]) by smtp.gmail.com with ESMTPSA id j24sm10934315pff.71.2019.10.28.13.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 13:29:51 -0700 (PDT) Date: Tue, 29 Oct 2019 01:59:45 +0530 From: Saurav Girepunje To: alcooperx@gmail.com, kishon@ti.com, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: saurav.girepunje@hotmail.com Subject: [PATCH] phy: broadcom: phy-brcm-usb-init.c: Fix comparing pointer to 0 Message-ID: <20191028202945.GA29284@saurav> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Compare pointer-typed values to NULL rather than 0 Signed-off-by: Saurav Girepunje --- drivers/phy/broadcom/phy-brcm-usb-init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/broadcom/phy-brcm-usb-init.c b/drivers/phy/broadcom/phy-brcm-usb-init.c index 3c53625f8bc2..2ea1e84b544b 100644 --- a/drivers/phy/broadcom/phy-brcm-usb-init.c +++ b/drivers/phy/broadcom/phy-brcm-usb-init.c @@ -707,7 +707,7 @@ static void brcmusb_usb3_otp_fix(struct brcm_usb_init_params *params) void __iomem *xhci_ec_base = params->xhci_ec_regs; u32 val; - if (params->family_id != 0x74371000 || xhci_ec_base == 0) + if (params->family_id != 0x74371000 || xhci_ec_base == NULL) return; brcmusb_writel(0xa20c, USB_XHCI_EC_REG(xhci_ec_base, IRAADR)); val = brcmusb_readl(USB_XHCI_EC_REG(xhci_ec_base, IRADAT)); -- 2.20.1