Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3979225ybg; Mon, 28 Oct 2019 23:51:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyklLTnIekoIhREIUnNNaRl7WDE5cw+RMgsxhxleY0L8CxlOaBrXb8w/zvyB/Sh7+ckcHW2 X-Received: by 2002:aa7:cdc6:: with SMTP id h6mr24105378edw.243.1572331861087; Mon, 28 Oct 2019 23:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572331861; cv=none; d=google.com; s=arc-20160816; b=tbgYbyuPmJMmKjdn9MO7APdz0ApNzDjrlo47Azzcfy5Zc4xAI3rJH6LQJ0ZaAmVkjm vtX/gER+P4mRnQxGedC5z3fQFjSlEgZLIj76vS7GP2I3vbgWuKPEbOCAmwik+TC6ptRm oMDXzq/05YDGYsur2R554xAhoDs6U3gAlReHfaoT/BLYXNT7Fe5qfUWT8gAp3xgRDBtm yTdFjlM1NorRpKqPcleX7Vw2CJOSgbnRQbkiQtxafuUc2qRJJRW0YPyrtCGb65EsRb3O TVqsS59G3vTZdl0Au80N8MdlHuozbJLVwGZxnIPKdK8jkFIsFELW/vm7gGYpMKKKDuwY Ds3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=waTiOda65EZ2kTE8wzO/DQIBoqvsMm1mcEe1xhNDh1k=; b=c09CJwrFYqD+2l5D1fLB5gqhD5VAUwBytsHLDKgS+NuVr7kQJVW7/El/0fIyPdT5Tc 7mL3cUchUs7xTiTlgRCRxnI40Xx3ZrA9SGxsIK7R4i+gOBOQxOkssUQzFYEBvo0vMc4F jNaHMx83e7lR1afl8+0ULHa+pCknoE2Tt/GoeCnYptP2bPJie1ofxfVGFiWo3srfYkps gbo31H/JNUjpKoJiJnhe9Hn94LZb2Swtt1+ni5V2EX874nrtR7OrKSO6P6dFeUXJjG5a 9xQKnPgSgLngn5cA/4CyguNwQ5T2ASquhBf6tMPvfrnjGbjcDz/GWI2kWBhVtRhr6Zet SZWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ec21si7120264ejb.26.2019.10.28.23.50.37; Mon, 28 Oct 2019 23:51:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388422AbfJ1UxS (ORCPT + 99 others); Mon, 28 Oct 2019 16:53:18 -0400 Received: from mga17.intel.com ([192.55.52.151]:43583 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfJ1UxR (ORCPT ); Mon, 28 Oct 2019 16:53:17 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 13:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,241,1569308400"; d="scan'208";a="205279169" Received: from shrehore-mobl1.ti.intel.com (HELO localhost) ([10.251.82.5]) by FMSMGA003.fm.intel.com with ESMTP; 28 Oct 2019 13:53:14 -0700 Date: Mon, 28 Oct 2019 22:53:13 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org Subject: Re: [PATCH v2] tpm: Add major_version sysfs file Message-ID: <20191028205313.GH8279@linux.intel.com> References: <20191025193103.30226-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191025193103.30226-1-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 25, 2019 at 12:31:03PM -0700, Jerry Snitselaar wrote: > + return sprintf(buf, "%s\n", chip->flags & TPM_CHIP_FLAG_TPM2 > + ? "2.0" : "1.2"); This is not right. Should be either "1" or "2". /Jarkko