Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3980792ybg; Mon, 28 Oct 2019 23:52:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxv04Pq4ZhAQwfsSosyHuJAepfX3z+GxDr+wQbcTL9qkgrhDxHpUVmEyp6qUHZQTrUmnfC X-Received: by 2002:aa7:d95a:: with SMTP id l26mr14420169eds.12.1572331962114; Mon, 28 Oct 2019 23:52:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572331962; cv=none; d=google.com; s=arc-20160816; b=DDZn9xKI26BHzWp8Q4sl7e7wisVBitzW7Ki6FD9uDUEr2vbs+8FSvrSF1vw0EnVCwM JSID8ctRd++xKwz0uL4yflJNWkk19S8mEZ6OuLDXOaNvFNtMNBG4KmPTKkluZUJjLhdf ke3UlUBXKqBarydrpVSZ2z1a83THs459hIFRWrRkwuD/5Vb8YlSRtS47sdD4WBPY0mQs iomA4rsE4Bp+a8C0pE1o4aW+lF+mc74XDp45BcKldsfRDBbcjccg49yO0mz0kp8yfinz 3Zz1pXPO4+L0zb8dNgjNy+7IBSsWbhd9BDFjgKIgt9IFaMunNDPALx+pYoMuVTxeZtDW g25Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=dxvcykPXpysvuTXof/BVRPmzEA4u/z3c2gWNUrcze4g=; b=onZu734pfqtPLOKVZd4ZI06xOGqYSoflgHgicGMM3qaL3sxHxMZ4yTTkCwiD8gld8i BwxMi6+f+DIkzE1jdlF59yGCM2eHjg8AgKyKD70bqfXaOlTEL4ITpOIiqX+pE8HkZjxj 22ADP2YArsDprPvukAdG7eYU+rQANUe208gN9USUfj4LpAUfZGktdKBf59Mv9Vmo5inH gyGtto5tTKHYHhUOwQ768b9+Vxgxku/1L/vAx7AD9qAy4Imn4ZoV+bDpHMeSPM2avu9a eC/1BscdSqHqY8Rzvf5jodyzfMcSQcP5ARc2eWujt2mkQjGxZUj4vI/by41LcxoU0MIG JiMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91si9855833edy.188.2019.10.28.23.52.18; Mon, 28 Oct 2019 23:52:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388427AbfJ1U5A (ORCPT + 99 others); Mon, 28 Oct 2019 16:57:00 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:46850 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbfJ1U47 (ORCPT ); Mon, 28 Oct 2019 16:56:59 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K8wx210045TFNlm038wxR7; Mon, 28 Oct 2019 21:56:57 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 21:56:57 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Mark Brown , alsa-devel@alsa-project.org Subject: Re: [PATCH 18/46] ARM: pxa: corgi: use gpio descriptors for audio References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-18-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 21:56:56 +0100 In-Reply-To: <20191018154201.1276638-18-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:33 +0200") Message-ID: <871ruwmvvr.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann > @@ -41,6 +40,8 @@ > static int corgi_jack_func; > static int corgi_spk_func; > > +struct gpio_desc *gpiod_mute_l, *gpiod_mute_r, *gpiod_apm_on, > *gpiod_mic_bias; Can't this be static ? Otherwise : Acked-by: Robert Jarzmik Cheers. -- Robert