Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Oct 2019 17:27:00 -0700 (PDT)
From:   David Rientjes <rientjes@google.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] mm: rate-limit allocation failure warnings more
 aggressively
In-Reply-To: <20191028194906.26899-1-hannes@cmpxchg.org>
Message-ID: <alpine.DEB.2.21.1910281725270.114830@chino.kir.corp.google.com>
References: <20191028194906.26899-1-hannes@cmpxchg.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 28 Oct 2019, Johannes Weiner wrote:

> While investigating a bug related to higher atomic allocation
> failures, we noticed the failure warnings positively drowning the
> console, and in our case trigger lockup warnings because of a serial
> console too slow to handle all that output.
> 
> But even if we had a faster console, it's unclear what additional
> information the current level of repetition provides.
> 
> Allocation failures happen for three reasons: The machine is OOM, the
> VM is failing to handle reasonable requests, or somebody is making
> unreasonable requests (and didn't acknowledge their opportunism with
> __GFP_NOWARN). Having the memory dump, a callstack, and the ratelimit
> stats on skipped failure warnings should provide enough information to
> let users/admins/developers know whether something is wrong and point
> them in the right direction for debugging, bpftracing etc.
> 
> Limit allocation failure warnings to 1 spew every ten seconds.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: David Rientjes <rientjes@google.com>

It feels like the vmalloc warnings should be treated with their own 
ratelimit (pass a struct ratelimit_state * to warn_alloc()) but that's 
outside the scope of this particular change.