Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Oct 2019 20:57:08 -0500
From:   Rob Herring <robh@kernel.org>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc:     kishon@ti.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to
 json-schema
Message-ID: <20191029015708.GA29561@bogus>
References: <1571387933-23397-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1571387933-23397-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 18, 2019 at 05:38:53PM +0900, Yoshihiro Shimoda wrote:
> Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation
> to json-schema.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt |  70 --------------
>  .../devicetree/bindings/phy/renesas,usb2-phy.yaml  | 106 +++++++++++++++++++++
>  2 files changed, 106 insertions(+), 70 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml


> diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> new file mode 100644
> index 00000000..0f109c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/renesas,usb2-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car generation 3 USB 2.0 PHY
> +
> +maintainers:
> +  - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> +
> +properties:
> +  compatible:
> +    oneOf:

This:

> +      - items:
> +          - enum:
> +              - renesas,usb2-phy-r8a77470 # RZ/G1C

You can simplify to just:

         - const: renesas,usb2-phy-r8a77470 # RZ/G1C

> +      - items:
> +          - enum:
> +              - renesas,usb2-phy-r7s9210  # RZ/A2
> +              - renesas,usb2-phy-r8a774a1 # RZ/G2M
> +              - renesas,usb2-phy-r8a774b1 # RZ/G2N
> +              - renesas,usb2-phy-r8a774c0 # RZ/G2E
> +              - renesas,usb2-phy-r8a7795  # R-Car H3
> +              - renesas,usb2-phy-r8a7796  # R-Car M3-W
> +              - renesas,usb2-phy-r8a77965 # R-Car M3-N
> +              - renesas,usb2-phy-r8a77990 # R-Car E3
> +              - renesas,usb2-phy-r8a77995 # R-Car D3
> +          - const: renesas,rcar-gen3-usb2-phy
> +
> +  reg:
> +    # base address and length of the registers block for the PHY.
> +    maxItems: 1
> +
> +  clocks:
> +    # clock phandle and specifier pair(s).
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    # for RZ/A2
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      - const: fck
> +      - const: usb_x1
> +
> +  '#phy-cells':
> +    # see phy-bindings.txt in the same directory

Drop this so we don't have to fix later.

> +    enum: [0, 1]  # and 0 is deprecated.
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  resets:
> +    minItems: 1
> +    maxItems: 2

Needs 'items' to define each entry.

> +
> +  vbus-supply:
> +    $ref: /schemas/types.yaml#/definitions/phandle

Can drop this, *-supply already has a type.

> +    description: |
> +      Phandle to a regulator that provides power to the VBUS. This regulator
> +      will be managed during the PHY power on/off sequence.
> +
> +  renesas,no-otg-pins:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |
> +      specify when a board does not provide proper otg pins.
> +
> +  dr_mode:
> +    $ref: /schemas/types.yaml#/definitions/string

I think we already have a common definition, so just 'true' is enough.

> +    description: |
> +      indicates the working mode for the PHY. Can be "host", "peripheral", or
> +      "otg". Should be set if otg controller is not used.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/power/r8a7795-sysc.h>
> +
> +    usb-phy@ee080200 {
> +        compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> +        reg = <0 0xee080200 0 0x700>;
> +        interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&cpg CPG_MOD 703>;
> +        #phy-cells = <1>;
> +    };
> +
> +    usb-phy@ee0a0200 {
> +        compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> +        reg = <0 0xee0a0200 0 0x700>;
> +        clocks = <&cpg CPG_MOD 702>;
> +        #phy-cells = <1>;
> +    };
> -- 
> 2.7.4
>