Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5DB7AD30.60007@huawei.com>
Date:   Tue, 29 Oct 2019 11:08:32 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     zhong jiang <zhongjiang@huawei.com>
CC:     <bardliao@realtek.com>, <oder_chiou@realtek.com>,
        <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
References: <1571919319-4205-1-git-send-email-zhongjiang@huawei.com>
In-Reply-To: <1571919319-4205-1-git-send-email-zhongjiang@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

ping.
On 2019/10/24 20:15, zhong jiang wrote:
> The GCC complains the following warning.
>
> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  sound/soc/codecs/rt5677-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
> index 36c02d2..b412371 100644
> --- a/sound/soc/codecs/rt5677-spi.c
> +++ b/sound/soc/codecs/rt5677-spi.c
> @@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
>  	mutex_unlock(&rt5677_dsp->dma_lock);
>  }
>  
> -struct page *rt5677_spi_pcm_page(
> +static struct page *rt5677_spi_pcm_page(
>  		struct snd_soc_component *component,
>  		struct snd_pcm_substream *substream,
>  		unsigned long offset)