Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Roger Quadros <rogerq@ti.com>
CC:     Pawel Laszczak <pawell@cadence.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        Rahul Kumar <kurahul@cadence.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: gadget: Don't manage pullups
Thread-Topic: [PATCH] usb: cdns3: gadget: Don't manage pullups
Thread-Index: AQHViYCigHhLS+QXN0CJz1D+9q4PbKdn8nSAgAK+9ICAAHFQgIAF16UA
Date:   Tue, 29 Oct 2019 03:12:34 +0000
Message-ID: <20191029031223.GA26815@b29397-desktop>
References: <20191023090232.27237-1-rogerq@ti.com>
 <BYAPR07MB4709A6212601A75DCB1A25ACDD6B0@BYAPR07MB4709.namprd07.prod.outlook.com>
 <20191025031343.GA13392@b29397-desktop>
 <83a1da01-19d6-65a9-aecd-2027fd62a272@ti.com>
In-Reply-To: <83a1da01-19d6-65a9-aecd-2027fd62a272@ti.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4021C72590E4AE43B655CF2F274B9E0E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dcaedf75-761c-487d-f132-08d75c1dd86d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 03:12:34.9975
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bFiFeiCfsf1idm9bYreu8r+dvQeUJMTGTmKat+z5wUqAYf+9gkMP7yvGfrbdWd7RsjzFR1oFl5exTmK5G3cF4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5149
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-10-25 12:59:17, Roger Quadros wrote:
> Peter,
>=20
> On 25/10/2019 06:13, Peter Chen wrote:
> > On 19-10-23 09:17:45, Pawel Laszczak wrote:
> > > Hi,
> > >=20
> > > Reviewed-by: Pawel Laszczak <pawell@cadence.com>
> >=20
> > Hi Roger & Pawel,
> >=20
> > Assume gadget function has already enabled, if you switch host mode
> > to device mode, with your changes, where the device mode will be enable=
d
> > again?
>=20
> When it switches from device mode to host the UDC is removed. When we swi=
tch
> back from host to device mode the UDC is added, so,
>=20
> usb_add_gadget_udc_release()-> check_pending_gadget_drivers()->
> udc_bind_to_driver()->usb_udc_connect_control()->usb_gadget_connect()->
> gadget->ops->pullup()

Thanks. I have another question how you decide when to store UDC name
to /sys/kernel/config/usb_gadget/g1/UDC? Do you have a user daemon program
to monitor VBUS or external connector? At host mode, the store operation
will fail due to there is NO UDC.

--=20

Thanks,
Peter Chen=