Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4013963ybg; Tue, 29 Oct 2019 00:27:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQ7Fu1atI51/YaxD0gzEazNGq17aErURZaQVXCJY6nmU4KMzhJK3pQmNfhuj/ERhZt8kME X-Received: by 2002:a50:fb87:: with SMTP id e7mr15578750edq.268.1572334045900; Tue, 29 Oct 2019 00:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572334045; cv=none; d=google.com; s=arc-20160816; b=Mx5J/yScosYqZqIY2WX1pnah0nQx5XbcZsF3MVwtrGuEtpqYjGUdRzzy2W3bZ8lacI RUw+TxLwus0W8GGOchsCT/y3km/c/IpJNt0Qnm0Fj++RnnpEfdbgi6FXGH9Gq4ju1m7t fUT1ltKmQw0Rq+EypfXiRHLUMFC/Ytjzq8NfR2yFldONyNhJIz9flaDkd5EJL09KpDny Jj8edpinVSeRs+GO4MkjGNER4VLxxA6yoja3JHPPznh5eeOLJh8vTIqPfgnZD5NKtB5v n7oGBWT8NFvKvmso6jlWyvygZKaXB8oEo53rLmqYsosLbB0nAr6UqK10vAqmrDhfcJvh yNng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:openpgp:from:references:cc:to :dkim-signature; bh=lEg/oM5SucuiXfeCKgoTcpzVKGMmKNrKswd9kWJjG6c=; b=XN+wyb9lqFfCB1jvO51RBaThY4ZrCA5ZSZjIv5Q3UWQC1yhHRqEIAIkowy33yxIYEG Evdr7talbIWpk+xtpHqFipbwVdrL2dElbpp9AT8anzgEiIGSh0Hr5B+3RtXFCpWrDxRh xFmrAX+Gayh/zx80f9WGsUkQFhp5vQATrj438wgy/XP7byCw78R+6IHtuHTKyTZQmfWc kqWFd7BVr4tQm64SNavBE6kbN4UXoRH5A+fvfwF5y6zpBAUxyU9EziB8ymGEaK1kYIbb 4mVTeULp5DsWhRbLmXiNgXA1LZWadpxzIK6Qj9xjAMydJMyqpj2J9HkuDMhF9UQYDZ4P kvLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=LeiLiNSm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k10si8581414ede.132.2019.10.29.00.27.02; Tue, 29 Oct 2019 00:27:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=LeiLiNSm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731639AbfJ2Ejc (ORCPT + 99 others); Tue, 29 Oct 2019 00:39:32 -0400 Received: from gateway36.websitewelcome.com ([192.185.195.25]:42937 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726708AbfJ2Ejc (ORCPT ); Tue, 29 Oct 2019 00:39:32 -0400 X-Greylist: delayed 1337 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Oct 2019 00:39:31 EDT Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id A3467400C3AA9 for ; Mon, 28 Oct 2019 22:25:17 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id PIwTioqmD3Qi0PIwTiC4yO; Mon, 28 Oct 2019 23:17:13 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:Subject:From:References:Cc:To:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lEg/oM5SucuiXfeCKgoTcpzVKGMmKNrKswd9kWJjG6c=; b=LeiLiNSmT5qaU5JVzquhIHKQjM 8RbDa28EPKsMTaUkd0GVmX8kwOPme5doKcqir2aZB59QgYR2J9qVmpstsTd0e/FHkMf9oMb/aKHZ0 7GYcARbo6CTbdJzvhfrdNS5mef+6jyzSoGbF0OkNfdFQ/BGuP9j+0wg6xH8HYcvbrkGO5NHYr9VqL YwK7no4LM5QXhfSmnCSg2OjL9/soo0E07VOIsND5/N8ZdpBYhnQlYCMT8nEhMEdAcIZitMridHjnH uZs/h64YdnzUaKn2+ll6nhJcBiC7Ewo0mKYbG7FMZf2/7Dr4lZE/bO3bii7a57OkjtQc/oWs+O1NQ 4A+486Eg==; Received: from [187.192.2.30] (port=54532 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1iPIwT-002w7F-Dk; Mon, 28 Oct 2019 23:17:13 -0500 To: Saurav Girepunje , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, groug@kaod.org, clg@kaod.org, christophe.jaillet@wanadoo.fr, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: <20191029034027.GA7226@saurav> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= mQINBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABtCxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPokCPQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA7kCDQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAYkCJQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Subject: Re: [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type Message-ID: <0f9297fc-a18e-d382-c7fc-a7e2600efc5e@embeddedor.com> Date: Mon, 28 Oct 2019 23:17:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191029034027.GA7226@saurav> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.2.30 X-Source-L: No X-Exim-ID: 1iPIwT-002w7F-Dk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [187.192.2.30]:54532 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is not actually a 'fix' I suggest you to rephrase the subject in a different way and remove the word 'fix' from it. On 10/28/19 22:40, Saurav Girepunje wrote: > Use true/false for bool return type in xive_spapr_cleanup_queue > function. > How do you find this? If you used a tool to find this, please mention it. Thanks -- Gustavo > Signed-off-by: Saurav Girepunje > --- > arch/powerpc/sysdev/xive/spapr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c > index 33c10749edec..74e3ffae0be6 100644 > --- a/arch/powerpc/sysdev/xive/spapr.c > +++ b/arch/powerpc/sysdev/xive/spapr.c > @@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc, > static bool xive_spapr_match(struct device_node *node) > { > /* Ignore cascaded controllers for the moment */ > - return 1; > + return true; > } > > #ifdef CONFIG_SMP >