Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC 1/2] vhost: IFC VF hardware operation layer
To:     Stephen Hemminger <stephen@networkplumber.org>
Cc:     mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com,
        linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        dan.daly@intel.com, cunming.liang@intel.com, tiwei.bie@intel.com,
        jason.zeng@intel.com, zhiyuan.lv@intel.com
References: <20191016010318.3199-1-lingshan.zhu@intel.com>
 <20191016010318.3199-2-lingshan.zhu@intel.com>
 <20191015190649.54ddc91c@hermes.lan>
From:   "Zhu, Lingshan" <lingshan.zhu@intel.com>
Message-ID: <2879733b-8b5f-3740-7b61-3f2043d3eaca@intel.com>
Date:   Tue, 29 Oct 2019 15:36:22 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20191015190649.54ddc91c@hermes.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 10/16/2019 10:06 AM, Stephen Hemminger wrote:
> On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan 
> <lingshan.zhu@intel.com> wrote:
>> + IFC_INFO(&dev->dev, "PCI capability mapping:\n" + "common cfg: 
>> %p\n" + "notify base: %p\n" + "isr cfg: %p\n" + "device cfg: %p\n" + 
>> "multiplier: %u\n", + hw->common_cfg, + hw->notify_base, + hw->isr, + 
>> hw->dev_cfg, + hw->notify_off_multiplier); 
> Since kernel messages go to syslog, syslog does not handle multi-line 
> messages very well. This should be a single line. Also, this is the 
> kind of message that should be at the debug level; something that is 
> useful to the driver developers but not something that needs to be 
> filling up every end users log.
Hi Stephen

Thanks for your comments, I have changed them in RFC V2, will send the 
patchset soon.
Thanks,
BR
Zhu Lingshan