Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191028153334.GA25863@linux-8ccs>
In-Reply-To: <20191028153334.GA25863@linux-8ccs>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Tue, 29 Oct 2019 18:02:39 +0900
Message-ID: <CAK7LNAQfeoPt1KApoa94RwVYo-LiPWxgit8=vzM2wfzHs+CajQ@mail.gmail.com>
Subject: Re: `make nsdeps` prints "Building modules, stage 2" twice
To:     Jessica Yu <jeyu@kernel.org>
Cc:     Matthias Maennich <maennich@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 29, 2019 at 12:33 AM Jessica Yu <jeyu@kernel.org> wrote:
>
> Hi!
>
> When running `make nsdeps`, I've noticed that "Building modules, stage
> 2" gets printed twice. Not a big deal, but a bit strange to see,
> especially since the second print is actually from the nsdeps target
> calling modpost again.
>
> $ make nsdeps O=/dev/shm/linux
> make[1]: Entering directory '/dev/shm/linux'
>   GEN     Makefile
>   DESCEND  objtool
>   CALL    /tmp/ppyu/linux/scripts/atomic/check-atomics.sh
>   CALL    /tmp/ppyu/linux/scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   Building modules, stage 2.
>   MODPOST 3316 modules
>   Building modules, stage 2.
>   MODPOST 3316 modules
> Adding namespace USB_STORAGE to module uas (if needed).
> Adding namespace USB_STORAGE to module ums-alauda (if needed).
> Adding namespace USB_STORAGE to module ums-cypress (if needed).
> Adding namespace USB_STORAGE to module ums-datafab (if needed).
> ....etc...
>
> It's due to calling the __modpost target twice, once for modules and
> once for nsdeps. I guess we could have the nsdeps target just call
> cmd_modpost, but then we still have the MODPOST XXXX modules line
> printing twice. Is there a nicer way to fix this? Again, it's not
> harmful, but probably confusing for people to see.
>
> Thanks,
>
> Jessica

I can fix this correctly.
Will send a patch soon.


-- 
Best Regards
Masahiro Yamada