Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] usb: cdns3: gadget: Don't manage pullups
To:     Peter Chen <peter.chen@nxp.com>
CC:     Pawel Laszczak <pawell@cadence.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        Rahul Kumar <kurahul@cadence.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20191023090232.27237-1-rogerq@ti.com>
 <BYAPR07MB4709A6212601A75DCB1A25ACDD6B0@BYAPR07MB4709.namprd07.prod.outlook.com>
 <20191025031343.GA13392@b29397-desktop>
 <83a1da01-19d6-65a9-aecd-2027fd62a272@ti.com>
 <20191029031223.GA26815@b29397-desktop>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <0c2c901c-a6f2-a81b-f5b1-e3f442d7c1ae@ti.com>
Date:   Tue, 29 Oct 2019 11:37:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191029031223.GA26815@b29397-desktop>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 29/10/2019 05:12, Peter Chen wrote:
> On 19-10-25 12:59:17, Roger Quadros wrote:
>> Peter,
>>
>> On 25/10/2019 06:13, Peter Chen wrote:
>>> On 19-10-23 09:17:45, Pawel Laszczak wrote:
>>>> Hi,
>>>>
>>>> Reviewed-by: Pawel Laszczak <pawell@cadence.com>
>>>
>>> Hi Roger & Pawel,
>>>
>>> Assume gadget function has already enabled, if you switch host mode
>>> to device mode, with your changes, where the device mode will be enabled
>>> again?
>>
>> When it switches from device mode to host the UDC is removed. When we switch
>> back from host to device mode the UDC is added, so,
>>
>> usb_add_gadget_udc_release()-> check_pending_gadget_drivers()->
>> udc_bind_to_driver()->usb_udc_connect_control()->usb_gadget_connect()->
>> gadget->ops->pullup()
> 
> Thanks. I have another question how you decide when to store UDC name
> to /sys/kernel/config/usb_gadget/g1/UDC? Do you have a user daemon program
> to monitor VBUS or external connector? At host mode, the store operation
> will fail due to there is NO UDC.
> 

Yes, user space needs to monitor /sys/class/usb_role/6000000.usb-role-switch/role

When it becomes "device" the UDC is available and it can prepare to configure
the UDC.

Could you please give your Ack for this patch if it is OK? Thanks.

cheers,
-roger

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki