Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4268873ybg; Tue, 29 Oct 2019 04:46:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVBto2Wry+FLxglw9yCpcC99Twzsj26O2SO7SCP3XlMythyq4KzWNXxyN02BvN9huBZo+A X-Received: by 2002:a17:906:6942:: with SMTP id c2mr2743089ejs.152.1572349586495; Tue, 29 Oct 2019 04:46:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572349586; cv=none; d=google.com; s=arc-20160816; b=Xk1JW/e8YoOGc+U8dwKK6qj2PGvA+e60yNeAQx1Um1+0m6e/5W8XWG+ydmP42lqnUD yeE0AUDNfpkw7QB1FrLkKbGEuZTnCA1734K8mbRHcfCm4Ws+OwnvIkPRqKP7dRzvW5wO FaEaR1mZr8tqSKXb0xwuZ9vgo1j9S4vlC6/oODzRf9kdjfV+8l8OJ8pudERFIZ//sMGu enX5y9p8oBHeZ37DOvT7zMkikNNl3j4WzaTGyYxhb75CISuDA791lvXItJJSJNshuuNj b+cssy4XZoAKuFH1GRAOG9Ha3eCHELyy3QeCsWP58kDLc1G/ITQhJvoXhlxS15YKmunY bYKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=M83Iy4PUSKtgLbhNDvSjjiCu9pY50pItVp7oVDhWeQg=; b=vBR0GscQQydJXVTO7+NOnmRH3nyY9lTKHshW/gAKwbq8TTFZlhv6gfSdJYyMt8cnNq UVD8vp4JZC1ynZfQoHENj1hEyfd66Ds4SYU1hmUQVEFUAONBdHZDAUj/lXwfkoGRko2o wb+OKoMI0tqyT60CEU5WdrABbKq+ws2bslRMuEVxyVFW3/C2ETSVeLFQ5b8lGSBHTdGX XSItwz+IBc+lM6fPCmeSTniDf3V/lWUNwSC0SwPqjgf8Px2pPSi4a0NJ/x1kMPcHnyCl 7XkhpxJcVMNYc0O9qi2uNy5wJM5MwgKUbnN2R/G2RmZgk7qoXR7y30X8m3Hj3BAAva2S wahw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=VsTB+FtJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d25si10065759edb.19.2019.10.29.04.46.03; Tue, 29 Oct 2019 04:46:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=VsTB+FtJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730932AbfJ2Ln3 (ORCPT + 99 others); Tue, 29 Oct 2019 07:43:29 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:42860 "EHLO mail-lj1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730394AbfJ2Ln3 (ORCPT ); Tue, 29 Oct 2019 07:43:29 -0400 Received: by mail-lj1-f172.google.com with SMTP id a21so14877353ljh.9 for ; Tue, 29 Oct 2019 04:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M83Iy4PUSKtgLbhNDvSjjiCu9pY50pItVp7oVDhWeQg=; b=VsTB+FtJJL6fTlT2oLENyReJFw1K/M/Z3nMaE20bpM79KdW4rlM/PRdZv3dK4rbfFr 0xgf5gIE/l2eJjOMF9hcIL1Mw2xWmC1RbMXZxdUKHCPJa3QPgNI6srbHoIc2nMvBfWNg fZluwfI2ueosXeisHRvFAmJ0Q9jLOU7/tpgmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M83Iy4PUSKtgLbhNDvSjjiCu9pY50pItVp7oVDhWeQg=; b=MJSpXePbsaiBiy+Gsgg5CT8hvtrefaNyAJCMgi7PkMITrEcCh+ufHUeg7Yo/OFD/fn z5vH1wlEZVC2W7SmHxwgaAqmJm7vWI3glc73EoV/EgFCoxwoN1AxpkODmvblCGukyeCr EzTxOFUz82XR2youQSD3uuFswBDtHVgdGgxnkEl9LO8yWoHTPzk/PGv35o7MnPNTLdyG xhJMpd7DXfwgU1+mBlWmuuWqF2qPAj8384NvEth2wkXGQ5zcslN9+9Z2ZAwn43WJO3Un CnTfBxqgbE0yFbD02vLv/5tUF08oN86LD8Ejl0Gq9PROrcioNg1MRbwhtEhNjrl7LtDV SFQA== X-Gm-Message-State: APjAAAVnHkb9fpYJdXHVrgtcijbAyRRhTrgxehvVL/aPHDiVeKTz61Ke xyR1jecU98we2oBatjDJQoXdh9Sec8YJrsH1 X-Received: by 2002:a2e:9e4c:: with SMTP id g12mr2362730ljk.62.1572349406342; Tue, 29 Oct 2019 04:43:26 -0700 (PDT) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id u11sm3315927ljo.17.2019.10.29.04.43.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2019 04:43:25 -0700 (PDT) Subject: Re: detecting misuse of of_get_property To: Dan Carpenter Cc: Luc Van Oostenryck , Dan Carpenter , linux-sparse@vger.kernel.org, LKML References: <20191029104917.GI1944@kadam> From: Rasmus Villemoes Message-ID: Date: Tue, 29 Oct 2019 12:43:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191029104917.GI1944@kadam> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/10/2019 11.50, Dan Carpenter wrote: > This should probably work? I haven't tested it, but yes, something like that. Can you also do the case of struct property::value, i.e. handling struct property *p = ...; u32 *v = p->value; Thanks, Rasmus