Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbWAJJTD (ORCPT ); Tue, 10 Jan 2006 04:19:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932145AbWAJJTD (ORCPT ); Tue, 10 Jan 2006 04:19:03 -0500 Received: from smtp.osdl.org ([65.172.181.4]:32458 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932118AbWAJJTC (ORCPT ); Tue, 10 Jan 2006 04:19:02 -0500 Date: Tue, 10 Jan 2006 01:18:44 -0800 From: Andrew Morton To: "Bryan O'Sullivan" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Message-Id: <20060110011844.7a4a1f90.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 20 "Bryan O'Sullivan" wrote: > > This arch-independent routine copies data to a memory-mapped I/O region, > using 32-bit accesses. It does not guarantee access ordering, nor does > it perform a memory barrier afterwards. This style of access is required > by some devices. Not providing orderingor barriers makes this a rather risky thing to export - people might use it, find their driver "works" on one architecture, but fails on another. I guess the "__" is a decent warning of this, and the patch anticipates a higher-level raw_memcpy_toio32() which implements those things, yes? How come __raw_memcpy_toio32() is inlined? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/