Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4416509ybg; Tue, 29 Oct 2019 06:54:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgbDr2HXlasB5sjc9TvYNYx11Y2odZIwmzhPjU5dj9ZsX8pZbV667WuwRkGgDrMVRFW+uR X-Received: by 2002:a17:906:4c97:: with SMTP id q23mr3334277eju.78.1572357243247; Tue, 29 Oct 2019 06:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572357243; cv=none; d=google.com; s=arc-20160816; b=ozWbi4vmhhGbDmECB100EvitoxEk3GeuZff+MJi9kkjC76LdpkWZ75BoxXwz49NKfr l+yYtQ3ulRIwFKgAAmKfBGTsF47lZz27nW/e4gBzWNMmxEE0BYxlEOyrnf2x9C4i0TWz pDlN+NZahjpgX4tvRUT1GujLLHQ1xRLOHBjYzNxz/Aj8pKpY+Y4m256AotXR7XUSUzpd EInnwYZbU0dzxz7Ov6Gu0AK0l5Lnt1I+aE7J2bxXC3nj/AWdQCDfQ1nygVZAES8I8eWk 6uY+bSFpctL9Ew4RGza5eMI/DGC028gNkWrXO21i9nnCypchaBQPBR4aaVX/Q4+CwCSt FNlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+Ptrz2Yswaus+WKDG/vA8NkrbE6i0FJ85P0xohydacQ=; b=CfCmMBJYFd0k01pFVIQ0cnrwXZgGuoSwfoKoanCOEwvuR1v4q+6chbZ9ILevoE6/iA p7V4wON0dEKcRuj5ulY75lrNFXPxAb2ZJ8eLmY9ENxMLg7X1TWLGIEOdHS+xiCgLuk9D ysL++irfL8P45bC3OV0MZ+0QzDZy9O3O8GTuQo0/Zw0BeCuYEq4sUrSzGoMULODspAdp /bZ23Iu0S9MH/bxo0lieZ0NImKYyWeO6lDMNsZvQ+ZOkxqIdMIxxnRdwTwQRoxbuIt2u 4jN6lYhwimFYDNUUb87kZpzUVpF8uaSicz42rud89gr6g+aI65dxdzs6qKiXWnh5Dnn3 tHLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bIwIy3Wf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si9965351edi.318.2019.10.29.06.53.39; Tue, 29 Oct 2019 06:54:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bIwIy3Wf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388957AbfJ2NvF (ORCPT + 99 others); Tue, 29 Oct 2019 09:51:05 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26859 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388802AbfJ2NvF (ORCPT ); Tue, 29 Oct 2019 09:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572357064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+Ptrz2Yswaus+WKDG/vA8NkrbE6i0FJ85P0xohydacQ=; b=bIwIy3WfalptrpmuhKEZawE1vJtp29PhYBB11AAHS1GoRejlawbrKM737MAe1OlQDUDfXz DMnkJz89lW7aJeozM5JYqgKS0/u7BPrMxJiuBbTsgvJyw34nCZ2lmGe+XsfKECgSIPZkdX LADtV05ZiuC6nhFr/4s0bZJ6ahNXuyQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-gah7qXDgP22w51ewU25bFw-1; Tue, 29 Oct 2019 09:51:00 -0400 Received: by mail-wm1-f72.google.com with SMTP id f2so882629wmf.8 for ; Tue, 29 Oct 2019 06:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UlvxO01Z2Ul860RxIp3leF/YeqCFOTpWgj3ZwcjunwQ=; b=rnDbw+ipZxGCrh7zXPrkADlJq9b1kG85kshEoAkJDMx3Oh/ruoJ6yjkhVipTqiiWBQ OoBjxOqajSr+zcuOW04N5Jdpjl7kiZpgDuCltgKpAYVJnKnmtpKKedWptJoLus7HPAIT ykMpbMAeOzr6oRfD5OXCJPN1krVoM6CN41H0edlxp0iO4n1t0uQWM//IvUzuuPtgFjD4 c5Mo0qyUeEZGQz3/T1wzjkliHym4K2dwkWfoCDstgXgz5UwO9c/ep7hWSON0LqW7TeXl 6M1sm7n0mA7J4DcsWgubRMUxpuhR11Oq2+DRHr8RHi2dRgU2DaizXlpr4US3toXeeAaz C0rA== X-Gm-Message-State: APjAAAUdMr9M+TLyhmzGt/h8GL7SgfHxCgS5cxS8wC7YLMeRQV26GBmU 8Xfd+zh0yRBzkGRm0vnvDfPiUm2xG5xGeP4FeB1GRuFWeq9omrf5PlYCYYAJr/cSbIVKQVSfhvS WSQAsNSRTa1JhulSH+kkbOIon X-Received: by 2002:a5d:4606:: with SMTP id t6mr19071451wrq.173.1572357059286; Tue, 29 Oct 2019 06:50:59 -0700 (PDT) X-Received: by 2002:a5d:4606:: with SMTP id t6mr19071429wrq.173.1572357059102; Tue, 29 Oct 2019 06:50:59 -0700 (PDT) Received: from mcroce-redhat.mxp.redhat.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id 189sm2556920wmc.7.2019.10.29.06.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 06:50:58 -0700 (PDT) From: Matteo Croce To: netdev@vger.kernel.org Cc: Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S . Miller " , Stanislav Fomichev , Daniel Borkmann , Song Liu , Alexei Starovoitov , Paul Blakey , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 0/4] ICMP flow improvements Date: Tue, 29 Oct 2019 14:50:49 +0100 Message-Id: <20191029135053.10055-1-mcroce@redhat.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-MC-Unique: gah7qXDgP22w51ewU25bFw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series improves the flow inspector handling of ICMP packets: The first two patches just add some comments in the code which would have s= aved me a few minutes of time, and refactor a piece of code. The third one adds to the flow inspector the capability to extract the Identifier field, if present, so echo requests and replies are classified as part of the same flow. The fourth patch uses the function introduced earlier to the bonding driver= , so echo replies can be balanced across bonding slaves. v1 -> v2: - remove unused struct members - add an helper to check for the Id field - use a local flow_dissector_key in the bonding to avoid changing behaviour of the flow dissector Matteo Croce (4): flow_dissector: add meaningful comments flow_dissector: skip the ICMP dissector for non ICMP packets flow_dissector: extract more ICMP information bonding: balance ICMP echoes in layer3+4 mode drivers/net/bonding/bond_main.c | 77 ++++++++++++++++++++--- include/net/flow_dissector.h | 20 +++--- net/core/flow_dissector.c | 108 +++++++++++++++++++++++--------- 3 files changed, 160 insertions(+), 45 deletions(-) --=20 2.21.0