Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4469906ybg; Tue, 29 Oct 2019 07:39:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXwYpkpDHXiKmesG0k1/IeEBAASrLgbfa2EHN97OXqRofEyWYrBMIoMTHuTFPKkC/QKhQv X-Received: by 2002:a50:bb48:: with SMTP id y66mr26323782ede.66.1572359947773; Tue, 29 Oct 2019 07:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572359947; cv=none; d=google.com; s=arc-20160816; b=RlsgNQv4lIj3vt9NEf2V9pEarwPEE582Djp5whtLQ+tV1127zkzRouF1e4Uk9Yc/Oz tT5yO+yJeVBfM/wAXiUx6ldRYqKoOVr+h76AkutJA/S4wI8YmWAAMqKAIM2WLLMDYTzd 8uuNdueroVgJcC3o6iElJJUxukW+okB18CS6GKqBwZxqJYc2VP9PnLoBeiTuTYrlD8zA IPcpOvu9S2vWow3i7Vx1iX5a9J3eJ3UBuSdL7+UAuA5wsAdOKj1smgdCz/GGjJX2xVv0 aBuRw42O2WI28VWGE+Adis081/OGzBeKTzn4RBR1wkU/7Kh91rebYWX/KG5UhxgXhHRJ miRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=a8mYbXXK5+KQUQaIvwcfrpjKf765samV6cQUxQNL5/o=; b=b5XIOxnwXf0sBWaoQUxH55wv3XwynMhVIx8eiCuRCPiVoCIAjoYADXVdo/Ogx9RRJa YQWYAP4EXglifVr2ME5Yo7VhWAJkXjxmSlxxDSpWA8sNu+0girM2ZFjbzoXu2prfr2h7 tM/OcBFsEuwBEWFLUoWKyf6G5g/zQPpPrH96Rj4a9eFRDdF5kk1ZgtbdQZvDoY2DcqJ7 XpReIBY5tgfT6lwlI0OE3wF24CeqJmt1m4cDJCVFEd+FT37zFnBvaHZExB7PkAvyUeab 8pi+iy7Niqs7vmN70i1EO3VZ3GtjHZ5jlQk4QM3MSqGgn8Bq9gcIPWGRAhnPur/15XYR /yFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=O31fbQcp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a11si8407516eju.31.2019.10.29.07.38.43; Tue, 29 Oct 2019 07:39:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=O31fbQcp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389417AbfJ2Oh0 (ORCPT + 99 others); Tue, 29 Oct 2019 10:37:26 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50787 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389185AbfJ2OhZ (ORCPT ); Tue, 29 Oct 2019 10:37:25 -0400 Received: by mail-wm1-f66.google.com with SMTP id 11so2871925wmk.0 for ; Tue, 29 Oct 2019 07:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a8mYbXXK5+KQUQaIvwcfrpjKf765samV6cQUxQNL5/o=; b=O31fbQcpDlQPaRDMeDghKQyKCpUZLsxpwu5wp8yldw9TK1V9CNDL4LgeBq9uR+2RGU ZjKJfJPZgpHiq3YdbZwMZPw9/RupSHfV+4O4Z5Nbe1YaYCM2hI3wpBupabJz6x77n3ug GhibiP9aLjoivl9amK7q9d+E+dGxrhAdMc4FJ2by+d54SbGyhS1b78g5i6PG1E6lhXMb CsYCOCOtkiSbxWs+bpBnQIA4YRmFwor5bXbUBkgsl8kWWHlNRjYCJmNf0ngNRywGoNv4 PAKHgYlpuy54myGByRZTIBDXAyFCUqGvePGyDkK2up/0Xj/5VJTozHUssa87+G31WlCK WZ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a8mYbXXK5+KQUQaIvwcfrpjKf765samV6cQUxQNL5/o=; b=TFoBe1/t46CoT32MFCMgO1uqw79WJANVs52mhdfxWaXdf+jZorpzZE9qfsupKlgv8g ktDHVMAsVbfouHlNYIYpZxrHva2t09JXSD3KRA/NcYmNux3JLBguqfcwC8mCao8OLkG+ qr8ToGscZaLFQ6knb3PMk+TqqN6Cn9fLKACDRJTL4KzZpOjgkM/gM80iwWMdKxkYbXKa aDmX7fJd3cBIdSugYsqvOEFGdaKQp4kxuuzNsugqUF6O4KaG3ssKgP+cC36x90RTyPqz n1WX1A8KeEUm0iGwIy7I2FXHTTUF5HXQxkY6c/rRjT7xp3LdRYqtOCffRsAPWZoYHbL0 SeOQ== X-Gm-Message-State: APjAAAV+IUyJqnrEwL9b7EuGWcFy8olWOgEn/ro2GOPeYOkIJ6zUr9LR uIY+Sp6EO2+ZKM6IT/7XTmcwJg== X-Received: by 2002:a05:600c:410:: with SMTP id q16mr4391860wmb.169.1572359843859; Tue, 29 Oct 2019 07:37:23 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id b66sm3229561wmh.39.2019.10.29.07.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 07:37:23 -0700 (PDT) Date: Tue, 29 Oct 2019 14:37:22 +0000 From: Matthias Maennich To: Julia Lawall Cc: Masahiro Yamada , Jessica Yu , Coccinelle , Linux Kernel Mailing List Subject: Re: Warning message from 'make nsdeps' when namespace is lower cases Message-ID: <20191029143722.GB33177@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Tue, Oct 29, 2019 at 02:38:36PM +0100, Julia Lawall wrote: > > >On Tue, 29 Oct 2019, Masahiro Yamada wrote: > >> Hi. >> >> When I was playing with 'make nsdeps', >> I saw a new warning. >> >> If I rename USB_STORAGE to usb_storage, >> I see 'warning: line 15: should usb_storage be a metavariable?' >> Why? I think it comes from spatch. > >Yes, it would come from spatch. > >> It should be technically OK to use either upper or lower cases >> for the namespace name. > >What is normally wanted? Uppercase or lowercase? There is no (documented) preference or convention yet. The existing namespaces (USB_STORAGE and MCB) use upper case. While technically both should work, I have a personal preference for consistently using upper case. Is there a way to suppress this warning as I agree that it might be confusing? Cheers, Matthias > >julia > >> >> Just apply the following, and try 'make nsdeps'. >> >> >> diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile >> index 46635fa4a340..6f817d65c26b 100644 >> --- a/drivers/usb/storage/Makefile >> +++ b/drivers/usb/storage/Makefile >> @@ -8,7 +8,7 @@ >> >> ccflags-y := -I $(srctree)/drivers/scsi >> >> -ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_STORAGE >> +ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=usb_storage >> >> obj-$(CONFIG_USB_UAS) += uas.o >> obj-$(CONFIG_USB_STORAGE) += usb-storage.o >> >> >> >> >> >> >> >> >> >> >> -- >> Best Regards >> Masahiro Yamada >>