Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4493514ybg; Tue, 29 Oct 2019 08:01:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqylN3VCNUpF7STGbzIRdnFAOi7kk/Zm/li6VMnbaaVbAWqS46Lk+0VYlOHA3QLMFOxQ7JxK X-Received: by 2002:aa7:d945:: with SMTP id l5mr26601243eds.279.1572361296433; Tue, 29 Oct 2019 08:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572361296; cv=none; d=google.com; s=arc-20160816; b=hqBrnPYGnfqLEF1UtziQEiYjA33SPy1KQfU5uXvYUqbCLBz+9vRi3vk7CjqfYs+pO1 vVAZ2J7VUXMd0TvajicvYhNqtDkDUiSAShs2PR/Ge/dxv1rayHBHPoko4gfHg3xmXjoi ZsI4cPAc6gkrTSLfAdwUKRNfufEkO1WdRyVCMGi7SrEqMwb9iBRNzd3kEdyqKf8zTf8R jA/8LIONIP0Ai5kM+u5coAQ5SZs0bImrI4TDG47gTqOSRTOJsifI+p+uI5xXfSHO/pmH Djz7SfT+GzvE9Ws8mWk8MeahJYmAL0yXWNg8KRVZ1OxypRwQLn8lYu/YT90VFUQiu/65 nBJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=Sgk+v/JBBykXaruVof4fHS4r6RoKrgPSot9IkS8LgnZMQk7Dg2KIilf/5DpgTUmETk s9HnC88umZFukAqnisNrllOnAlQxyl2kAkrc/B2Jg7eXB/84S0P28nIBlCFG62rpRiDU vzE4e/ioqKXes5CBSPzoL5xszC9yNpOUaIgMdzTImK+ygrFSjQgVZ4M88bMOe+0KecjI 0RStRxggas7LILGIYzhv0SiNrtVJpAmv4PyXpH9eBYKrL8XWndcm6RWQnaratTLXYHJm 6OR9MEJOQymUcwcPuccEKK9LbEIUtXvnMx9lwUwEdpRRiC+DSbubaT9F7I724b47VjR6 WDXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oaXpskJC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g33si9712277eda.117.2019.10.29.08.01.11; Tue, 29 Oct 2019 08:01:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oaXpskJC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389809AbfJ2O6a (ORCPT + 99 others); Tue, 29 Oct 2019 10:58:30 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:33843 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389800AbfJ2O6a (ORCPT ); Tue, 29 Oct 2019 10:58:30 -0400 Received: by mail-vs1-f67.google.com with SMTP id f8so2788324vsg.1 for ; Tue, 29 Oct 2019 07:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=oaXpskJCNt4XXGtwMjTYcVHqnsYcgfy+b60L4FecmVgfx2bvqI3yhshilu7EhsJGED HVdSB0Mv5TcTKihKo/g4eEfeVwotJc2pI/ADqKHZEUoEExQ8N64ZUrSpvrgw7sbAwcUo G8C1XTdibyo5hC2gTMCccdjPP6Z7mxoeFR5bZbqRMZsoVWGGmDx8HQchm2K6hW0QYpRv HRjGUXBFVueW3Q+RJJFP0NnoifQLM3IFNuHcGmbETxhTmNvuBTS6uCiEZGdBLtOEo9uU 6qxbkxwqypztHkWqNz0CPNUGK4ythXELpQL7YDWxZ7XSIYBgmIgmz8a8hl717594vq9q f0Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=INaKV0DYYwI21YhiPXxDR7MAGNymkp1vrthhcPaHnNqPOmcT67uaZeexAsTb+ykxsM rgTb0bghoeUQlYfj23OSKSCk3rfOcNfRBANOqQTb4fXzVvpyWqY5zOQAqjJnKP/0LqSG QhrcWdKqg0pDFNLGjgOqNXOX9twqMBGou2knz6fvnVl3kBtbqRQaZqGIB2Ph/s05Sy8D Xsbhl1gvBfnFbio91RFrbWi/WsmzWn/DYq9yI5RfiyHcoxZ+pafBMv35bO5NnIT5DQ// 1rMBPQnXKzwe0XnSM3o13jynTzgrfS82pgKoyyRzc3ARJTzF0h+mtsbu1JPb2vAjyd+1 Do4g== X-Gm-Message-State: APjAAAX3PQSPf61RItG0fe+oAFyfs3ZvJ04SgQFJT8bW/l+TJfNsymzF HcmUXP6IDG4fgd/LjmMzhwtyAeb3/anaDaVP/0YcGA== X-Received: by 2002:a67:7944:: with SMTP id u65mr2109606vsc.10.1572361109404; Tue, 29 Oct 2019 07:58:29 -0700 (PDT) MIME-Version: 1.0 References: <20191024202703.8017-1-chris.packham@alliedtelesis.co.nz> <20191024202703.8017-3-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20191024202703.8017-3-chris.packham@alliedtelesis.co.nz> From: Linus Walleij Date: Tue, 29 Oct 2019 15:58:17 +0100 Message-ID: Subject: Re: [PATCH v4 2/2] gpio: Add xgs-iproc driver To: Chris Packham Cc: Bartosz Golaszewski , Rob Herring , Mark Rutland , Ray Jui , Scott Branden , bcm-kernel-feedback-list , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 24, 2019 at 10:27 PM Chris Packham wrote: > This driver supports the Chip Common A GPIO controller present on a > number of Broadcom switch ASICs with integrated SoCs. The controller is > similar to the pinctrl-nsp-gpio and pinctrl-iproc-gpio blocks but > different enough that a separate driver is required. > > This has been ported from Broadcom's XLDK 5.0.3 retaining only the CCA > support (pinctrl-iproc-gpio covers CCB). > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v4: > - rename the config option to GPIO_BCM_XGS_IPROC and place alphabetically > - sort #includes alphabetically Patch applied, great work on this patch, it's very lean and clean now! Got a minor thing I wanna look at, will send a patch on top if I find it useful. Yours, Linus Walleij