Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 29 Oct 2019 16:44:23 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     SAURAV GIREPUNJE <saurav.girepunje@gmail.com>
Cc:     pbonzini@redhat.com, rkrcmar@redhat.com,
        sean.j.christopherson@intel.com, vkuznets@redhat.com,
        wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        saurav.girepunje@hotmail.com
Subject: Re: [PATCH] arch: x86: kvm: mmu.c: use true/false for bool type
Message-ID: <20191029154423.GN4131@hirez.programming.kicks-ass.net>
References: <20191029094104.GA11220@saurav>
 <20191029101300.GK4114@hirez.programming.kicks-ass.net>
 <20191029134246.GA4943@saurav>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191029134246.GA4943@saurav>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 29, 2019 at 07:12:46PM +0530, SAURAV GIREPUNJE wrote:
> On Tue, Oct 29, 2019 at 11:13:00AM +0100, Peter Zijlstra wrote:
> > On Tue, Oct 29, 2019 at 03:11:04PM +0530, Saurav Girepunje wrote:
> > > Use true/false for bool type "dbg" in mmu.c
> > > 
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > ---
> > >  arch/x86/kvm/mmu.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > > index 24c23c66b226..c0b1df69ce0f 100644
> > > --- a/arch/x86/kvm/mmu.c
> > > +++ b/arch/x86/kvm/mmu.c
> > > @@ -68,7 +68,7 @@ enum {
> > >  #undef MMU_DEBUG
> > >  
> > >  #ifdef MMU_DEBUG
> > > -static bool dbg = 0;
> > > +static bool dbg = true;
> > 
> > You're actually changing the value from false to true. Please, if you
> > don't know C, don't touch things.
> Hi,
> 
> Thanks for your review.
> I accept that I have given wrong value "true" to debug variable. It's my bad my typo mistake.  
> I will make sure that I will not touch your exclusive C code where we can assign 0/1 to a bool variable,
> As you have given me a free advice, I also request you to please don't review such small patches from newbie to discourage them.

I will most certainly review whatever I want, and clearly it is needed.