Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4577137ybg; Tue, 29 Oct 2019 09:11:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxr6ZlESDQfzXYstV44Xd/G/Gtlp509EJyJXLW7Dc4CbMjPN6rmngbMlTFP2h2cyGq58D1i X-Received: by 2002:aa7:d615:: with SMTP id c21mr26485900edr.167.1572365518422; Tue, 29 Oct 2019 09:11:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572365518; cv=none; d=google.com; s=arc-20160816; b=1CsfOacIloIKIkrMzwy1psWGDwjhtZbGZ9KaAa2Fq+ORLjuEDk4P6VHG9+q5pcMSBb hHHSuFHoG6MLtoLmAHpupQ9X24TMLagCY8KqHSTh91s53WTSMx7iAT9t64X9eAmZeCtW nAbBbLOnLaV2q3K784CiPeLyhTJkfn35rpPeyzNKj5h51yaYGI04SeROzrOexnBTtKlv lI9h+IrssG174OB/G/H+YYoCVVoEu0JjVndEpeT4mAUdbCFvlOD2TPPPoUtMvtsnhaw9 oFQe8qbN2BTdlyquE8nP6tPQPsUF0ovSP65PrrNmLBx3Fs/B5WsTq9IwEQyj+kb+ok1S PdKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=j+nHODI6ZHbhOoC2zrdSlrl+XosEJ6M/+YRfoolJ4oM=; b=IIpPJk2A9Iw+EX1s29z/9WF/Y34eNm1oRNmR+N9zSF/5aPDSFMW7RxEFJXwjc3j85N LBa53+WmMA19Z49DLutJgxYgjWLTUrBPEABezNGUf/c8aTcG4uMU5qQ4HGmEpFLIJ4oo G7GDqie/I5FtX0hBdX/gtXhdoMIn7xx0kxAnBaJTmTvm2z+dio9Y4/7wisYtW0k4s7l5 +q8d6depFD9AJb+5rq4oe8Ib5xGodVPfs1vjPJ2Gt6zUxk0prPWOJkNGaChZgPywZvnp bIuG4FtckUrmd+g6gS7XiwdvhfkUA6Kb5LlyBNR9Mx5d+hMuzWuwDmAosSeu49VcFkhX dS/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4si8477445ejc.218.2019.10.29.09.11.34; Tue, 29 Oct 2019 09:11:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390345AbfJ2QJc (ORCPT + 99 others); Tue, 29 Oct 2019 12:09:32 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:59234 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390200AbfJ2QJc (ORCPT ); Tue, 29 Oct 2019 12:09:32 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iPU3f-0006Vk-M6; Tue, 29 Oct 2019 17:09:23 +0100 Date: Tue, 29 Oct 2019 17:09:23 +0100 From: Florian Westphal To: Praveen Chaudhary Cc: davem@davemloft.net, fw@strlen.de, kadlec@netfilter.org, pablo@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Zhenggen Xu , Andy Stracner Subject: Re: [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet. Message-ID: <20191029160923.GB876@breakpoint.cc> References: <1572301675-5403-1-git-send-email-pchaudhary@linkedin.com> <1572301675-5403-2-git-send-email-pchaudhary@linkedin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572301675-5403-2-git-send-email-pchaudhary@linkedin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Praveen Chaudhary wrote: > No need to update skb->csum in function inet_proto_csum_replace16(), > even if skb->ip_summed == CHECKSUM_COMPLETE, because change in L4 > header checksum field and change in IPV6 header cancels each other > for skb->csum calculation. Can you resend this and submit this patch to netfilter-devel@vger.kernel.org? You may add: Reviewed-by: Florian Westphal