Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 29 Oct 2019 09:04:34 +0000
Message-ID: <86o8xzylb1.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Zenghui Yu <yuzenghui@huawei.com>
Cc:     <eric.auger@redhat.com>, <james.morse@arm.com>,
        <julien.thierry.kdev@gmail.com>, <suzuki.poulose@arm.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <kvmarm@lists.cs.columbia.edu>, <linux-kernel@vger.kernel.org>,
        <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH 2/3] KVM: arm/arm64: vgic: Fix some comments typo
In-Reply-To: <20191029071919.177-3-yuzenghui@huawei.com>
References: <20191029071919.177-1-yuzenghui@huawei.com>
        <20191029071919.177-3-yuzenghui@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Zenghui,

On Tue, 29 Oct 2019 07:19:18 +0000,
Zenghui Yu <yuzenghui@huawei.com> wrote:
> 
> s/vgic_its_save_pending_tables/vgic_v3_save_pending_tables/
> s/then/the/
> 
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
>  include/kvm/arm_vgic.h      | 2 +-
>  virt/kvm/arm/vgic/vgic-v3.c | 2 +-
>  virt/kvm/arm/vgic/vgic-v4.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
> index 0fb240ec0a2a..01f8b3739a09 100644
> --- a/include/kvm/arm_vgic.h
> +++ b/include/kvm/arm_vgic.h
> @@ -240,7 +240,7 @@ struct vgic_dist {
>  	 * Contains the attributes and gpa of the LPI configuration table.
>  	 * Since we report GICR_TYPER.CommonLPIAff as 0b00, we can share
>  	 * one address across all redistributors.
> -	 * GICv3 spec: 6.1.2 "LPI Configuration tables"
> +	 * GICv3 spec "LPI Configuration tables"

Why the change here? Pointing to the chapter in the spec is pretty
helpful, given that it is 800 pages long (although it should mention
what revision of the spec this refers to). For example, it should say
something like "IHI 0069E 6.1.1 ...".

Thanks,

	M.

-- 
Jazz is not dead, it just smells funny.