Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa3.microchip.iphmx.com: domain of
  Tudor.Ambarus@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com;
  envelope-from="Tudor.Ambarus@microchip.com";
  x-sender="Tudor.Ambarus@microchip.com";
  x-conformance=spf_only; x-record-type="v=spf1";
  x-record-text="v=spf1 mx a:ushub1.microchip.com
  a:smtpout.microchip.com a:mx1.microchip.iphmx.com
  a:mx2.microchip.iphmx.com include:servers.mcsv.net
  include:mktomail.com include:spf.protection.outlook.com ~all"
Received-SPF: None (esa3.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com;
  envelope-from="Tudor.Ambarus@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: oidpa1YA4tangmGVBQCjLfeEk4Sksp3GxMesfEwiPKasmaBtk5+HYhCBMxY9YbMsLBkdkJb6yT
 ZkfGwYjyJZ1Jv3JllX372D7/FkWrBLN1w9Y7rL6/HebOxFkZKoscDTh897Z+w072JW9z7DzE9A
 Kjo2cD5agZVX1wuPBgLAZjKHO/b9gNHe/xNqND/mHxsCNs+uSabTgw6wXp9qaT2p76L7tmYjgP
 E3FV/A4JvcXVcDKObDmlSwFhYtpOF27wqHtnb7vwT9UPoUNp8OrSxWBLGSB4mxn3tl4zx7rRll
 EGc=
From:   <Tudor.Ambarus@microchip.com>
To:     <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
        <boris.brezillon@collabora.com>
CC:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <Tudor.Ambarus@microchip.com>
Subject: [PATCH v3 24/32] mtd: spi-nor: Print error message when the read back
 test fails
Thread-Topic: [PATCH v3 24/32] mtd: spi-nor: Print error message when the read
 back test fails
Thread-Index: AQHVjkpyLds+N6zyek6FFtmFwXB1pA==
Date:   Tue, 29 Oct 2019 11:17:27 +0000
Message-ID: <20191029111615.3706-25-tudor.ambarus@microchip.com>
References: <20191029111615.3706-1-tudor.ambarus@microchip.com>
In-Reply-To: <20191029111615.3706-1-tudor.ambarus@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.9.5
x-originating-ip: [83.166.207.93]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c56aced4-1365-444e-9847-08d75c6194ac
x-ms-traffictypediagnostic: MN2PR11MB3823:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR11MB3823D1EC4F1D85569FA406C6F0610@MN2PR11MB3823.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:813;
x-forefront-prvs: 0205EDCD76
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(39860400002)(346002)(136003)(376002)(396003)(189003)(199004)(478600001)(8676002)(4326008)(8936002)(4744005)(66066001)(14454004)(36756003)(6512007)(107886003)(86362001)(11346002)(2616005)(476003)(486006)(6436002)(1076003)(2201001)(71200400001)(71190400001)(446003)(81156014)(81166006)(6486002)(50226002)(99286004)(66946007)(386003)(316002)(52116002)(6506007)(102836004)(76176011)(26005)(2501003)(305945005)(186003)(6116002)(110136005)(25786009)(2906002)(14444005)(256004)(54906003)(3846002)(64756008)(66446008)(66556008)(66476007)(5660300002)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB3823;H:MN2PR11MB4448.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: S3QPxWLnrdPUzyvap4mPOAxo7SSH/jfGyeIYPwV9DQslYBhEBdBXSbTCoflRepLOyT15rLTEVc+scXadC2a4PmA3g63tzypebspisqgEuYKq3JLT7ACF1dzbQ+GffCK3pRc0Gt3qHK9I4ToZ/yPTJQVFloGnx7bbMVPxhmdy1DGUuZwE2iCYvKZLpvS/kwqWxFh140kiChNk2whkOXh1nWDhJ5Na9J3TIOL9wqNFXsjP7B/zLosDkkrGULSUxHg7ApKXcJDGmIAsc/JzO5NLgHhXHRLGckKAz6iRlv9o3hqvAovU2ovsaph+LjaaD+heBSjcVW3XTUu2tIGtWwg+DB5r1RQJAViV4QHYdKJZMs0NJdOZ63eFCeQQjT1DRR1WWQI1tiLxgGeGmSqKfhrso3qSxDc5eeB3VcN3xOqbEewbQX5hK9GNwGHjSuaLE5R9
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c56aced4-1365-444e-9847-08d75c6194ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 11:17:27.4335
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: R4iLuVofgvu+29duWtgwp6wB5oOH54vIeKojhyq9LpDUmhg4mRhQoLmoJs4Pk5krsjEM4xh3KnpNaoKteHivadJdwGk62ZL/ZkPaY6reRjM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3823
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Tudor Ambarus <tudor.ambarus@microchip.com>

Demystify where the EIO error occurs.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/mtd/spi-nor/spi-nor.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 5b30fc73fdba..30ce83426266 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -974,7 +974,12 @@ static int spi_nor_write_sr_and_check(struct spi_nor *=
nor, u8 status_new)
 	if (ret)
 		return ret;
=20
-	return (nor->bouncebuf[0] !=3D status_new) ? -EIO : 0;
+	if (nor->bouncebuf[0] !=3D status_new) {
+		dev_err(nor->dev, "SR: read back test failed\n");
+		return -EIO;
+	}
+
+	return 0;
 }
=20
 /**
--=20
2.9.5