Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <8301f887ce091340b6662371ab2bd1628a06118e.camel@decadent.org.uk>
Subject: Re: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to
 cifsInodeInfo
From:   Ben Hutchings <ben@decadent.org.uk>
To:     Pavel Shilovskiy <pshilov@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Cc:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        Denis Kirjanov <kda@linux-powerpc.org>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Steven French <Steven.French@microsoft.com>
Date:   Tue, 29 Oct 2019 14:15:45 +0100
In-Reply-To: <DM5PR21MB0185257853E50A73C593B891B6660@DM5PR21MB0185.namprd21.prod.outlook.com>
References: <lsq.1570043210.379046399@decadent.org.uk>
         <lsq.1570043211.844466427@decadent.org.uk>
         <DM5PR21MB0185257853E50A73C593B891B6660@DM5PR21MB0185.namprd21.prod.outlook.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-aXEdqtHx4Y9xfbklpuEp"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-aXEdqtHx4Y9xfbklpuEp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2019-10-28 at 22:19 +0000, Pavel Shilovskiy wrote:
> > -----Original Message-----
> > From: Ben Hutchings <ben@decadent.org.uk>
> > Sent: Wednesday, October 2, 2019 12:07 PM
> > To: linux-kernel@vger.kernel.org; stable@vger.kernel.org
> > Cc: akpm@linux-foundation.org; Denis Kirjanov <kda@linux-powerpc.org>; =
Ronnie Sahlberg <lsahlber@redhat.com>; Steven French <Steven.French@microso=
ft.com>; Pavel Shilovskiy <pshilov@microsoft.com>
> > Subject: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to =
cifsInodeInfo
> >=20
> > 3.16.75-rc1 review patch.  If anyone has any objections, please let me =
know.
> >=20
> > ------------------
> >=20
> > From: Ronnie Sahlberg <lsahlber@redhat.com>
> >=20
> > commit 487317c99477d00f22370625d53be3239febabbe upstream.
[...]
> We have recently found regressions in this patch that are addressed in th=
e following two patches:
>=20
> cb248819d209d ("cifs: use cifsInodeInfo->open_file_lock while iterating t=
o avoid a panic")
> 1a67c41596575 ("CIFS: Fix use after free of file info structures")
>=20
> So, I would suggest either to apply those two patches above or to revert =
this one.

Thanks for pointing thse out.  I will try to include those in a later
update.

Ben.

--=20
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.


--=-aXEdqtHx4Y9xfbklpuEp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAl24O4EACgkQ57/I7JWG
EQlO+Q/9ERJdUmTM9CMXqx1b2UvtT8KH+GAuF75obVUHZCN3ysjyLINP5J+I/QjQ
MfefJCJXd7+kFtp7kTe6w+EdxEms6QCQzHmGDGMSzW3wrdMD0ct5N0/3VED8Jqsz
f0kchBegnpNbThc5xMnhpStkcASRlWmrhGMrMIKrN6ybR8doroJ7hD2R6EQ28RPd
j62twwV3v0G1a3BX1DwDuLH3ZuGJhiDZE4AZdLIdZfhZXc9+QX9SOPcCV/i3Zxvp
d/TWzbfaX9jC/K+FlbFIzTYRAIKKLnvSpHEZTnj3qzYR3iO93qvTiILUcxB6z5j5
2cHwcKwINMh/cL+elIVGDqztqcc4vIdqybtGGXkmjRyH3B5BW/3wvpACGHW2Fghw
2f44m4jGHk/VfKemmbBD2NSegKpzffM5g2ioTa6aZT55oMD4yA2Caj3KfGK4nuUc
s5lYXuwXbhRH7HdvIJkK5juoEppbZVvuR/IYGNyXZpqw7ANL+t8AdUu99uyPXSMn
OUGZD25awMkcXTTSD/IMZhrRg4HeaMbQw56QjC/fLwbiwP7BCQowodoXiX82HfKC
GmjfAJsNdJHJzX8s9cnv0lkkGAs9SWO8h5YvHMavoZGmkRzAy4cf+8tUUy0ImR/3
RIcr81FYQ6NLLBC2oWZ3DpbkAg5osjeF2JthnyeuP7w+QW2wVts=
=8ShN
-----END PGP SIGNATURE-----

--=-aXEdqtHx4Y9xfbklpuEp--