Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4800536ybg; Tue, 29 Oct 2019 12:35:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxi+ZDTbuKF77kj6aURMOq2uvnGm+yR2Lu9Av4r5tqjMxbQkW9t/Pc2+u8Pj2bEF3yFvd2 X-Received: by 2002:a50:b3b6:: with SMTP id s51mr17154205edd.88.1572377710930; Tue, 29 Oct 2019 12:35:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572377710; cv=none; d=google.com; s=arc-20160816; b=CY+jVqQCAkyPjPgFJcx/th5jIswbSkF3HIhcOSHEFdq3rjVb68kq9TpSquGPMH/ChC 1v709frt1l+uCj2MdVzTrBY3kXAGOlizb4RYm/92cbhdK5iqBjUZ6R264d1/PXZXvnGB pfa6CgOF+k/382UCj9QTle2vfavO8k7yMUH9W3Gmp3jdmtL0x/1gf9xmF0/ZrGyeci3m Zi9lwXiqME6SKQ6qehI5DX4nMBC0M9Phm3ldgXBzI1wCynXHa3+17f8PFq5zHxsccE46 DbuP3ZA8rzT82KCSGpHbrGHKKXOyfuiFDeBSLpc11BT5wbcWqs9zniuN0M4uMVCBhhj6 ogKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1YpYMICvtfF10jHRaLvbJtkSuykMWavtIqdMoqx0V/U=; b=tUuH6+X4XTsJZprxhkYxSXlhMwIj99YZrpFvNqLs8dIZvtDdbnvCj1lSPCUY3kqMEz QWn9KyXJRxkv0ZP76j2NT0Pov33XciEZVfRipZNAlfHVaphixv1RBT0FWh1FJcEDQNfl 0o+8xS4RsXsylVW4HOoK2yDpLBia3ISHgyc3y07IV6c3qlNM8LgSjDUWviM1J9mvdeJY ypKeuzeNqWeCLnUTrZ7g3RgkXh3iEnAjgNpNrYlw2UIo0Cwc/69LXioBXcD0drf8yYUX 6E64Z8mWACWTAAVLvKburY+EEIogCwBOl1zfWtBuUwLMN+1pAMiGkyb0llHpnhw66VHM 9NmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=WHQJCFka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si3860231eda.359.2019.10.29.12.34.47; Tue, 29 Oct 2019 12:35:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=WHQJCFka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388425AbfJ2NV1 (ORCPT + 99 others); Tue, 29 Oct 2019 09:21:27 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:42781 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728735AbfJ2NV1 (ORCPT ); Tue, 29 Oct 2019 09:21:27 -0400 Received: by mail-qk1-f196.google.com with SMTP id m4so12133467qke.9 for ; Tue, 29 Oct 2019 06:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1YpYMICvtfF10jHRaLvbJtkSuykMWavtIqdMoqx0V/U=; b=WHQJCFkajK2zHSstOrIxbWsS1IvSJSZMSpBhufG6qZpWrgzSB9vqgMRV9FGitJYID3 bPuu5YirlOH/CAnekaWkyG9Bw7BYn+sMMGtZ76XGjzwGABnqiWl/pRMk/nP6B4hd78o8 DAYufsmEBg4Ujd5vLGNfzqa/mB/dOgbi1h65CTvP2k9tZEItx6Tm7+pDyg0DIblUd5lo uchd5GkkZ2gM5KBcgd2UaMEb+9DwZNoEDtpWUR657Il+c0C0qwo0xceW5l/yIzdhIrvF IPJFVTia5E2YkKDqqHlLOn8dfU7BhuAOPPe/+jhpwjlbB8f+KO/p4UpOFPHFJUFT9R/1 kPbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1YpYMICvtfF10jHRaLvbJtkSuykMWavtIqdMoqx0V/U=; b=lB/03hfMWBYF2bXYmi2T1i2PiZvdhTqi2Lt9e8LfCdKe21uwPNzz2QOpMJPOxJtTvJ E0t5okQABAGmk2Tn2sDlHBDJNACrEBFS8VkomAbmHc4MOEQyjsnJCHsA3cOCAFTJT/po DcCtQnTRYi3pjHF7khe85PHuoAaG9tgDy9Kcef8PqkHSUEFuBiWoDUedzxft8On4o8wz DMeMpCjFxnqv54xJeRLxxWrc9vmODJ+kjPNFQQ82Yr8p8+73kPnK+NoSYWv7dJpdM5d5 dp/BxYFNkrYCTh/qBCCAXnX7BzchGIg50oiEg4UTxVY/HZU59poEAj0hqkFbvgwajrlJ iKOw== X-Gm-Message-State: APjAAAUj94fVn6uPN+Hnluete8Aa5OnF1MrMSJjhfciIo7QXmLStH/yn dN236fNoP9peqs9ov1fDZgTOmqv5 X-Received: by 2002:a37:9e89:: with SMTP id h131mr21656614qke.477.1572355286090; Tue, 29 Oct 2019 06:21:26 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::8ce9]) by smtp.gmail.com with ESMTPSA id o2sm2083929qkf.68.2019.10.29.06.21.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2019 06:21:25 -0700 (PDT) Date: Tue, 29 Oct 2019 06:21:21 -0700 From: Tejun Heo To: Saurav Girepunje Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] fs: kernfs: file.c: Drop the condition with no effect. Message-ID: <20191029132121.GK3622521@devbig004.ftw2.facebook.com> References: <20191029095552.GA11561@saurav> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029095552.GA11561@saurav> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 03:25:52PM +0530, Saurav Girepunje wrote: > As the "if" and "else" branch body are identical the condition > has no effect. So drop the if,else condition. > > Signed-off-by: Saurav Girepunje Nack. Please read the comment right above. Thanks. -- tejun