Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4808127ybg; Tue, 29 Oct 2019 12:42:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYv3goQY5lNFig0UfphvuMqyQotdgfRkjnzWxYqh3hW+TRseXcmYH7AWIKoiTob4/D/oF0 X-Received: by 2002:a50:ed05:: with SMTP id j5mr4655084eds.108.1572378129108; Tue, 29 Oct 2019 12:42:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572378129; cv=none; d=google.com; s=arc-20160816; b=YTetM+Gtr8BPtenXvMna1065QRdrXR3W6g6l2SwUpaeGItppvb95i+5Ri2go9+BuT1 +LEZUxATXB6XtM6rZ7eBCpMQslHS9wpVWtYUuktp1H5GraB5sWZThmZNziOkLJ7LP6w2 nZ6b0QJvOQBpNkAk7/nkzklzffRv5bl417wjuNUTs0u6/RnzuD0nXD2WeRf1X0KTJCZT IX8iBLn+jOwN7/ymTj2vbi7dtg7pjuVdcH/k+ZXQ17EoRvkbPEvNqIoVoQZrrBX3Ukn9 Nv+J3IRuUTIRcAdtc3Nxa/ZUJa4YfNIxkH56zk9HhPvQVpBnZPP9eOS2nwcK653zjIRW vC2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ZT1h4VryA2wthS6A+f+Zm6rBjcB7Ostnjnhs7fAimsI=; b=dRnTdJftxJHk796CZuJEB96TY0zjR4ZGVJzlQWF6lOZnaiLmDaejN8UaZT13KyXFD3 DbWot44WSgulKuH2m7fnnPLBkHX39ReXz3ymhUwJj8l0WGXYG4nhj1YuzQ5YhNVjCj8A rprx9zdIImm6ld5UXIQL6fNFfVabNXL9xopvy8ONTe2Q7wqEyLe/cD11R3TajN9CiWP6 sRprGmI6e/CwJmcYnDHfhIt19fVcMujPOEsQ94yCvmRtGI3FRIU1y4HybsLTrCvcOQIZ 97k/RWGOcTn+aI9xWaO2G5vWdbUbxv4rmaVsHMoCviHTOFryVLIRvqr9ZdLazcdfsMOf +jOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=wBC98HFB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u59si11356964edc.193.2019.10.29.12.41.45; Tue, 29 Oct 2019 12:42:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=wBC98HFB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388954AbfJ2OB1 (ORCPT + 99 others); Tue, 29 Oct 2019 10:01:27 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:65397 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727255AbfJ2OB0 (ORCPT ); Tue, 29 Oct 2019 10:01:26 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 472YCl24Zrz9v02H; Tue, 29 Oct 2019 15:01:23 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=wBC98HFB; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id kQBmk6d20Oj7; Tue, 29 Oct 2019 15:01:23 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 472YCl11dzz9v023; Tue, 29 Oct 2019 15:01:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1572357683; bh=ZT1h4VryA2wthS6A+f+Zm6rBjcB7Ostnjnhs7fAimsI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=wBC98HFBxpusQdx5XlTeIcr0bnnfGYS7Qlpcqj8mQNmrXWJbSuoL5coLC2nGg8PoT NcE1hBTwJZVrl9s89SJ0iAqzZz5apgV9nouJ4rS7vRIVQB9NqDDE3YRmHO8qnq2ak7 mbJ0beqC6RRo5eutEcUwPuOkN+qaxHqtzEESSA8U= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 829B28B869; Tue, 29 Oct 2019 15:01:24 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id m5zGj5hczfzc; Tue, 29 Oct 2019 15:01:24 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C090B8B85C; Tue, 29 Oct 2019 15:01:23 +0100 (CET) Subject: Re: [PATCH v6 0/7] Powerpc/Watchpoint: Few important fixes To: Ravi Bangoria Cc: mpe@ellerman.id.au, mikey@neuling.org, npiggin@gmail.com, benh@kernel.crashing.org, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20191017093204.7511-1-ravi.bangoria@linux.ibm.com> <10cce8b1-8142-39d3-cd91-58b85dac7c8c@linux.ibm.com> From: Christophe Leroy Message-ID: Date: Tue, 29 Oct 2019 15:01:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <10cce8b1-8142-39d3-cd91-58b85dac7c8c@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/10/2019 à 05:54, Ravi Bangoria a écrit : > > > On 10/17/19 3:01 PM, Ravi Bangoria wrote: >> v5: >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2019-October/198069.html >> >> v5->v6: >>   - patch 6/7: mpe reported that the perf-hwbreak.c doesn't compile >> with older >>     gcc: >>          perf-hwbreak.c:182:2: error: dereferencing type-punned >> pointer will >>          break strict-aliasing rules [-Werror=strict-aliasing] >>              temp16 = *((__u16 *)target); >>              ^ >>     Fixed that. >> > > Hi Christophe, Are you ok with the series wrt 8xx? Yes it looks ok on my 885: root@vgoip:~# ./ptrace-hwbreak test: ptrace-hwbreak tags: git_version:v5.4-rc4-835-gb235e63aa9f0-dirty PTRACE_SET_DEBUGREG, WO, len: 1: Ok PTRACE_SET_DEBUGREG, WO, len: 2: Ok PTRACE_SET_DEBUGREG, WO, len: 4: Ok PTRACE_SET_DEBUGREG, WO, len: 8: Ok PTRACE_SET_DEBUGREG, RO, len: 1: Ok PTRACE_SET_DEBUGREG, RO, len: 2: Ok PTRACE_SET_DEBUGREG, RO, len: 4: Ok PTRACE_SET_DEBUGREG, RO, len: 8: Ok PTRACE_SET_DEBUGREG, RW, len: 1: Ok PTRACE_SET_DEBUGREG, RW, len: 2: Ok PTRACE_SET_DEBUGREG, RW, len: 4: Ok PTRACE_SET_DEBUGREG, RW, len: 8: Ok PPC_PTRACE_SETHWDEBUG, MODE_EXACT, WO, len: 1: Ok PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RO, len: 1: Ok PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RW, len: 1: Ok success: ptrace-hwbreak Also ok on book3s/32: root@vgoippro:~# ./ptrace-hwbreak test: ptrace-hwbreak tags: git_version:v5.4-rc4-835-gb235e63aa9f0-dirty PTRACE_SET_DEBUGREG, WO, len: 1: Ok PTRACE_SET_DEBUGREG, WO, len: 2: Ok PTRACE_SET_DEBUGREG, WO, len: 4: Ok PTRACE_SET_DEBUGREG, WO, len: 8: Ok PTRACE_SET_DEBUGREG, RO, len: 1: Ok PTRACE_SET_DEBUGREG, RO, len: 2: Ok PTRACE_SET_DEBUGREG, RO, len: 4: Ok PTRACE_SET_DEBUGREG, RO, len: 8: Ok PTRACE_SET_DEBUGREG, RW, len: 1: Ok PTRACE_SET_DEBUGREG, RW, len: 2: Ok PTRACE_SET_DEBUGREG, RW, len: 4: Ok PTRACE_SET_DEBUGREG, RW, len: 8: Ok PPC_PTRACE_SETHWDEBUG, MODE_EXACT, WO, len: 1: Ok PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RO, len: 1: Ok PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RW, len: 1: Ok PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, WO, len: 6: Ok PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RO, len: 6: Ok PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RW, len: 6: Ok success: ptrace-hwbreak Christophe