Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Bean Huo (beanhuo)" <beanhuo@micron.com>
To:     'Alim Akhtar' <alim.akhtar@samsung.com>,
        'Avri Altman' <avri.altman@wdc.com>,
        'Pedro Sousa' <pedrom.sousa@synopsys.com>,
        "'Martin K. Petersen'" <martin.petersen@oracle.com>
CC:     "'James E.J. Bottomley'" <jejb@linux.ibm.com>,
        'Evan Green' <evgreen@chromium.org>,
        'Stanley Chu' <stanley.chu@mediatek.com>,
        "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
        "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
        Can Guo <cang@codeaurora.org>
Subject: [PATCH v1] scsi: ufs: delete redundant function
 ufshcd_def_desc_sizes()
Thread-Topic: [PATCH v1] scsi: ufs: delete redundant function
 ufshcd_def_desc_sizes()
Thread-Index: AdWOYNFUHmkvcAl2Q/qT6qb+uQ79WA==
Date:   Tue, 29 Oct 2019 14:22:45 +0000
Message-ID: <BN7PR08MB5684A3ACE214C3D4792CE729DB610@BN7PR08MB5684.namprd08.prod.outlook.com>
Accept-Language: en-150, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: micron.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f5e0c7ad-7f8e-46f8-bb99-08d75c7b780c
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 14:22:45.9958
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vHiE6yIckNvR/BDdz/QYfIR+UF+dXyd48t0NdVYyP+mMDgtkgBmYm3cyjdXx3skh/nl2eXXUpnSHi5vxz3AvQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB4868
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Bean Huo <beanhuo@micron.com>

There is no need to call ufshcd_def_desc_sizes() in ufshcd_init(),
since descriptor lengths will be checked and initialized later in
ufshcd_init_desc_sizes().

Fixes: a4b0e8a4e92b1b(scsi: ufs: Factor out ufshcd_read_desc_param)=20
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
 drivers/scsi/ufs/ufshcd.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c28c144d9b4a..21a7244882a1 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6778,23 +6778,13 @@ static void ufshcd_init_desc_sizes(struct ufs_hba *=
hba)
 		&hba->desc_size.geom_desc);
 	if (err)
 		hba->desc_size.geom_desc =3D QUERY_DESC_GEOMETRY_DEF_SIZE;
+
 	err =3D ufshcd_read_desc_length(hba, QUERY_DESC_IDN_HEALTH, 0,
 		&hba->desc_size.hlth_desc);
 	if (err)
 		hba->desc_size.hlth_desc =3D QUERY_DESC_HEALTH_DEF_SIZE;
 }
=20
-static void ufshcd_def_desc_sizes(struct ufs_hba *hba)
-{
-	hba->desc_size.dev_desc =3D QUERY_DESC_DEVICE_DEF_SIZE;
-	hba->desc_size.pwr_desc =3D QUERY_DESC_POWER_DEF_SIZE;
-	hba->desc_size.interc_desc =3D QUERY_DESC_INTERCONNECT_DEF_SIZE;
-	hba->desc_size.conf_desc =3D QUERY_DESC_CONFIGURATION_DEF_SIZE;
-	hba->desc_size.unit_desc =3D QUERY_DESC_UNIT_DEF_SIZE;
-	hba->desc_size.geom_desc =3D QUERY_DESC_GEOMETRY_DEF_SIZE;
-	hba->desc_size.hlth_desc =3D QUERY_DESC_HEALTH_DEF_SIZE;
-}
-
 static struct ufs_ref_clk ufs_ref_clk_freqs[] =3D {
 	{19200000, REF_CLK_FREQ_19_2_MHZ},
 	{26000000, REF_CLK_FREQ_26_MHZ},
@@ -8283,9 +8273,6 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mm=
io_base, unsigned int irq)
 	hba->mmio_base =3D mmio_base;
 	hba->irq =3D irq;
=20
-	/* Set descriptor lengths to specification defaults */
-	ufshcd_def_desc_sizes(hba);
-
 	err =3D ufshcd_hba_init(hba);
 	if (err)
 		goto out_error;
--=20
2.7.4