Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <9dd814577107edc42c4469ee7c923e062a2b5368.camel@perches.com>
Subject: Re: [PATCH 2/4] thermal: stm32: fix IRQ flood on low threshold
From:   Joe Perches <joe@perches.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Pascal Paillet <p.paillet@st.com>, mcoquelin.stm32@gmail.com,
        alexandre.torgue@st.com, robh+dt@kernel.org, mark.rutland@arm.com,
        rui.zhang@intel.com, edubezval@gmail.com,
        amit.kucheria@verdurent.com, david.hernandezsanchez@st.com,
        wsa+renesas@sang-engineering.com,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Andy Whitcroft <apw@canonical.com>
Date:   Tue, 29 Oct 2019 10:24:50 -0700
In-Reply-To: <026e676e-0a6c-81ca-3af4-2832118b9ddf@linaro.org>
References: <20191029164537.1561-1-p.paillet@st.com>
         <20191029164537.1561-3-p.paillet@st.com>
         <8952e975-3bad-4b7d-49ff-b74af942008c@linaro.org>
         <f668de19e156bd7a1bf599d9ce1f9d4f4fca4095.camel@perches.com>
         <026e676e-0a6c-81ca-3af4-2832118b9ddf@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-10-29 at 18:21 +0100, Daniel Lezcano wrote:
> On 29/10/2019 18:15, Joe Perches wrote:
> > On Tue, 2019-10-29 at 18:11 +0100, Daniel Lezcano wrote:
> > > On 29/10/2019 17:45, Pascal Paillet wrote:
> > > > Fix IRQ flood on low threshold by too ways:
> > > 
> > > Can you state the issue first ?
> > > 
> > > > - improve temperature reading resolution,
> > > > - add an hysteresis to the low threshold: on low threshold interrupt,
> > > > it is not possible to get the temperature value that has fired the
> > > > interrupt. The time to acquire a new value is enough for the CPU to
> > > > become hotter than the current low threshold.
> > []
> > > > Signed-off-by: Pascal Paillet <p.paillet@st.com>
> > > > Change-Id: I3b63b8aab38fd651a165c4e69a2d090b3c6f5db3
> > > 
> > > Please remove the Change-Id tag.
> > > 
> > > Joe, Andy? checkpatch does not see the Change-Id, is it the expected
> > > behavior?
> > 
> > Yes.  It's after a sign-off so checkpatch doesn't care.
> 
> Ah, I guess it is for Gerrit but we don't want those Change-Id in the
> kernel history, right?

So remove it from the patch.

checkpatch is not a perfect tool.
checkpatch will never be a perfect tool.
It's not possible for checkpatch to be a perfect tool.