Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4824201ybg; Tue, 29 Oct 2019 12:58:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzj9tgTbAvNVQ3Hsu26IZrC8m3oJN11rEeZjZIzUFOLYCKwCohSasebrlAN7MDhCo1Hye5s X-Received: by 2002:a17:906:f48:: with SMTP id h8mr5271773ejj.106.1572379116523; Tue, 29 Oct 2019 12:58:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572379116; cv=none; d=google.com; s=arc-20160816; b=gB9Y+rR3R2bdSKSIxsO1Bkr3XMaebhfiHEOPo9/fMq+cDDFrnAi1BWovepgOgXSnMo CyDBWYTIKAlTpP3xlK4tKGk6A/XgrmkOKnUUxyQx0KWluJVOGsKtpTdzrh0ohJ+Fqe0M 78jAXb7Yest63B6IgxrLMx49DHcFfDKuPhll6SsU+aC0IA25iiqn1N3HXC8zRrmELGVH mfqO24xFheIL4ctbpqqycXvqxKzP2rjZvtk09S24Vb2xI/AGPAGQ6fEmnFGdIs/GmLUx e+E2t76nl1CBtLIRN99ks44Drqx4G7faQciZE2mzZrJTrQDfhJt/W0OonDpXSi3eHSmv KKSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=bBOjrvK9klWxZwvEpO0Xz4JEak+yd2k0UCdBbxralO8=; b=ZF8a0+7muc1MoNj/hRfia61oiszfCREzFjOmbuc7DBxePPClWwj/ybp2QRlJdHAYjm 80Fav4UnHTLEK3cAhM71f928En4ZFlI2SWVAuqz+2zjWWslj5Z306rw1U+QdyAfGNNXn FG+OTlcJ4M5F0GfyHOTiFVtSfZMUNfM2APDovIo8p5jRr2W7SQ4NUJ7Yg19HrjFEboRW e983Y3s6gcZqy3EPpFLiGXYDJ5QEK7tM62WdYpDELzWFgZ+VKRDBRkOOu+1pB1v0k+mI /ZrG8bk0/nMh85kRgVxKJtUIqcR23n41uNWOML2qLKPNSrujEGygl7ygP5UF6gRMtJRS TXyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ha17si8941655ejb.196.2019.10.29.12.58.12; Tue, 29 Oct 2019 12:58:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730746AbfJ2SGT (ORCPT + 99 others); Tue, 29 Oct 2019 14:06:19 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57756 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfJ2SGT (ORCPT ); Tue, 29 Oct 2019 14:06:19 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2C95F14CFC095; Tue, 29 Oct 2019 11:06:18 -0700 (PDT) Date: Tue, 29 Oct 2019 11:06:17 -0700 (PDT) Message-Id: <20191029.110617.1405330302630427488.davem@davemloft.net> To: xiaojiangfeng@huawei.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leeyou.li@huawei.com, zhanghan23@huawei.com, nixiaoming@huawei.com Subject: Re: [PATCH] net: hisilicon: Fix "Trying to free already-free IRQ" From: David Miller In-Reply-To: <1572011302-48605-1-git-send-email-xiaojiangfeng@huawei.com> References: <1572011302-48605-1-git-send-email-xiaojiangfeng@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Oct 2019 11:06:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiangfeng Xiao Date: Fri, 25 Oct 2019 21:48:22 +0800 > When rmmod hip04_eth.ko, we can get the following warning: ... > Currently "rmmod hip04_eth.ko" call free_irq more than once > as devres_release_all and hip04_remove both call free_irq. > This results in a 'Trying to free already-free IRQ' warning. > To solve the problem free_irq has been moved out of hip04_remove. > > Signed-off-by: Jiangfeng Xiao Applied, thank you.