Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1571687868-22834-1-git-send-email-vincent.cheng.xh@renesas.com>
 <20191025193228.GA31398@bogus> <20191029145953.GA29825@renesas.com>
In-Reply-To: <20191029145953.GA29825@renesas.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 29 Oct 2019 16:20:03 -0500
Message-ID: <CAL_JsqLteAdjk+4KQ2hd5m16irT9_70EAxNWdTDLFHCZkex2Bg@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT
 ClockMatrix based PTP clock
To:     Vincent Cheng <vincent.cheng.xh@renesas.com>
Cc:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 29, 2019 at 10:00 AM Vincent Cheng
<vincent.cheng.xh@renesas.com> wrote:
>
> On Fri, Oct 25, 2019 at 03:32:28PM EDT, Rob Herring wrote:
> >On Mon, Oct 21, 2019 at 03:57:47PM -0400, vincent.cheng.xh@renesas.com wrote:
> >> From: Vincent Cheng <vincent.cheng.xh@renesas.com>
> >>
> >> Add device tree binding doc for the IDT ClockMatrix PTP clock.
> >>
> >> +
> >> +examples:
> >> +  - |
> >> +    phc@5b {
> >
> >ptp@5b
> >
> >Examples are built now and this fails:
> >
> >Documentation/devicetree/bindings/ptp/ptp-idtcm.example.dts:19.15-28:
> >Warning (reg_format): /example-0/phc@5b:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> >
> >The problem is i2c devices need to be shown under an i2c bus node.
> >
> >> +          compatible = "idt,8a34000";
> >> +          reg = <0x5b>;
> >> +    };
>
> I am trying to replicate the problem locally to confirm the fix prior to re-submission.
>
> I have tried the following:
>
> ./tools/dt-doc-validate ~/projects/linux/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> ./tools/dt-extract-example ~/projects/linux/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml > example.dts
>
> How to validate the example.dts file against the schema in ptp-idtcm.yaml?

'make -k dt_binding_check' in the kernel tree.

Rob