Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp106950ybx; Tue, 29 Oct 2019 15:09:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwppcvZYnceP6IHSSjTBUOqMT/7WNoFISw3ipEBoEJGS5NAiaqgeX0H98QhNyEf/BOpBYfe X-Received: by 2002:a17:906:3053:: with SMTP id d19mr5808963ejd.109.1572386960617; Tue, 29 Oct 2019 15:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572386960; cv=none; d=google.com; s=arc-20160816; b=Oqt8eNyoom0FMdPg4vQQrwZigdkTxAv4MxZMvEfOQ9CQdV1azE3zBeQHAfa0R0r1yG VmhmEjVR7oJ/BzKoyP49n1l6kKETT42Wtchw+kfVqVnA/gMKuF0Vx+ZlueMU1ClNjXvM Vhj7vn2G23zDPNt4mvH+uhG5NP3oGdzCPqdmFsz1/w30HSm8NztF1tgCnw8heSpPYzHI wsa/q+IMQXoYwsoPz20+cTbVy0O/Qpmp0WjUc2y4A68HerlPb2PKyDElP33/WtzKS/lf Zs8xqXlDzlLOPlDBgAewCStSngoZmlN0C6QCxqfYmqf1VGSlWlNLoW3AUTU/slaC1TNq b+2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature; bh=NibxEBGYCnjU+gMxJTzBvOQSJh74N1uoQV8IyZK77hs=; b=NT0X/Ijbc6J95tTVzVsg+7OTgJ788UXuoRxksHkrV4AOrz6xaMntuywCKZl9a9RauM ujuLdImqHDafx1ppmlrunDX/i3W1bURy23A3GnwaMx64ZSdg9dVGhosPhwg3RFrF/O4D b19Jv8NnE1OCq8SPqnzJemrvZRC1ByjF/TNNTj57LHisOpJuXBfvGQ33QMBixCpqQPa9 caZAUY+2D1EpORADYd1z7Q8oeE/hu00NC90a5DNDYbes4QrEV30lmDkdJacZLiu1e9RT VzjKhJd+Io/qniZ5dRQAClo6xGabgwp0aGbQJ0+cjC86U8Kei4Dt6U7UNk6o7MvKFoTl GpXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b="A/NChKpM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o21si9202723eja.318.2019.10.29.15.08.57; Tue, 29 Oct 2019 15:09:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b="A/NChKpM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbfJ2R7x (ORCPT + 99 others); Tue, 29 Oct 2019 13:59:53 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:59332 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727379AbfJ2R7w (ORCPT ); Tue, 29 Oct 2019 13:59:52 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9THnDC8141162; Tue, 29 Oct 2019 17:59:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=NibxEBGYCnjU+gMxJTzBvOQSJh74N1uoQV8IyZK77hs=; b=A/NChKpM7JIuo4fcwZ0W0q7pFMnedx/bPjsJ+aGobzi6iRYZ6+1qtDpoMRfkf4Oq/e+c ijwA8v9OANZydb8P5NdYpaNk3GGW5VIu74LqcyqwAhbrMW3cGw9O4BiRbF7QW2O2PVGI QG75Nng9tPzAYJQZEw1x/VMaoP3zpD3mJUu+IZfhsZVYI2g4rUdBUy3iKl6KyZUG23I1 IFMTgHKgCVfg/Join7p9YEiw53iKBolAZDiQ5OZJZZcU34ECYwCtm/QN56f3hdwNt5Zj YbWv83YSBaJFWQvou2nE7PZ9kCG1FM89yiyZFahKuiM1fw/BpK3rezOJiZM/HV6uz55I 7Q== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2vve3qaxc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Oct 2019 17:59:38 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9THn4LK120202; Tue, 29 Oct 2019 17:59:37 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2vxpfdff8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Oct 2019 17:59:37 +0000 Received: from abhmp0022.oracle.com (abhmp0022.oracle.com [141.146.116.28]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9THxZlo028919; Tue, 29 Oct 2019 17:59:35 GMT Received: from dhcp-10-159-132-196.vpn.oracle.com (/10.159.132.196) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 29 Oct 2019 10:59:35 -0700 Subject: Re: [PATCH -next] soc: ti: omap-prm: fix return value check in omap_prm_probe() To: Wei Yongjun , Santosh Shilimkar , Tero Kristo Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org References: <20191011052436.76075-1-weiyongjun1@huawei.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Tue, 29 Oct 2019 10:59:34 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191011052436.76075-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9425 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=945 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910290159 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9425 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910290159 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/19 10:24 PM, Wei Yongjun wrote: > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 3e99cb214f03 ("soc: ti: add initial PRM driver with reset control support") > Signed-off-by: Wei Yongjun > --- Applied