Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp125543ybx; Tue, 29 Oct 2019 15:28:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxj36bPilGvkt2Ca8G/uU8A9+ciuEeTS5B7b9HB7ARBpkOBSuS9P3o23LyqsNKWmAk/5bSm X-Received: by 2002:aa7:cc18:: with SMTP id q24mr28151115edt.150.1572388113379; Tue, 29 Oct 2019 15:28:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572388113; cv=none; d=google.com; s=arc-20160816; b=casUOi/wySyTO/UMPp7BNsmDUDXtjAoht2bYXAOQTeK74G8OLvULvLXmA2t3XHaw/H mV/TV+9gIC9MFIVLtqbZHI9V8TOOwZTb/YfRrCMybB5GUUoSYR34UzVc738v3bJMW4dH edlGsDVSaRJIoh3A+m8LF2W6Tk54zVwYOIDbFhzeQthvSD9gI3nzwQWECKC9Dck5Q2xX NUo4b66pR3wI4taxEIIW8TGodmgvoavfdFUh/ox52WeL78rUb2g9Upl3PMMxRGCFxkwy H7uwbON1Ru7j2fP01qijtxQ8qOupYiBmS+JWU7o0W2su4tjV6dJCA/YHZPcI9BCz05sq ch1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hE/uiUmR+U9CTc3OVDUR9t14Efm2Al7uifBBD8ydPLQ=; b=CFcSi93XQ2cNjxnZCAq+jDLscsPF81JnzwN/c7hHsHZ5ixSpoQG66YtMFIlwZ42G/N YIfHidfO7e3HruHMwVPOBk3y6rToJLPOchxKCLltHu2g1erzJJNki900D5K0oMMlk4qH OHNkD9j6fDUWM9/CIyp/3dTXFCK4IpWMGIG+4pOtiqS9xwXX6seW9yyb8XUo1AYJ09/X dEvG1F5EhyQKadMfGIVfq7Fn69nUeNQM21kJx+jMoOyit9OG/4qkZkdo/g7iL6FuOiJx rz4C/FfeeO12Qp0SBvNbvtii30065a3gq9V9cPLJifOoUNOB3bCxmHfTU97uiTKShSWm 3O5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qRZ3CPOm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h22si57117edb.346.2019.10.29.15.28.08; Tue, 29 Oct 2019 15:28:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qRZ3CPOm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbfJ2WYo (ORCPT + 99 others); Tue, 29 Oct 2019 18:24:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:56718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbfJ2WYo (ORCPT ); Tue, 29 Oct 2019 18:24:44 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26E3B20717; Tue, 29 Oct 2019 22:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572387883; bh=D+kyyB7UXdE00h1hhFmw71lmhkWEAKdVovYsmlb2WwI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qRZ3CPOmd40eSHqwIK8VBuAx4hiXX4EPyBgU/uTUURAPCZaYXWZCI/j3mXKKbSbzg RBwJKOZV21whk4IdUkTm0RZwpShqaZWp3xEMmtI2pmfB5ghWCcpzZ0Nb1MGNZLLkDy cSZYruN+QnJ5d7cCe7HQzU5XR3+c/cFAKicpSvXc= Date: Tue, 29 Oct 2019 15:24:42 -0700 From: Andrew Morton To: Mike Kravetz Cc: cgxu519@mykernel.net, linux-mm , linux-kernel , David Howells Subject: Re: [PATCH] hugetlbfs: fix error handling in init_hugetlbfs_fs() Message-Id: <20191029152442.32bf51a13e48d9b2d83cd504@linux-foundation.org> In-Reply-To: <94b6244d-2c24-e269-b12c-e3ba694b242d@oracle.com> References: <20191017103822.8610-1-cgxu519@mykernel.net> <16e15cd0096.1068d5c9f40168.8315245997167313680@mykernel.net> <94b6244d-2c24-e269-b12c-e3ba694b242d@oracle.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Oct 2019 13:47:38 -0700 Mike Kravetz wrote: > It is assumed that the hugetlbfs_vfsmount[] array will contain > either a valid vfsmount pointer or NULL for each hstate after > initialization. Changes made while converting to use fs_context > broke this assumption. > > While fixing the hugetlbfs_vfsmount issue, it was discovered that > init_hugetlbfs_fs never did correctly clean up when encountering > a vfs mount error. What were the user-visible runtime effects of this bug? (IOW: why does it warrant the cc:stable?)