Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp191313ybx; Tue, 29 Oct 2019 16:43:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+1jFJwntSaQXx/zncvyKtxBLna6xZiud1L7K7V1ObqPgq5xtiV4ai1Ex4Hy1HFlrm66GR X-Received: by 2002:a05:6402:1e3:: with SMTP id i3mr21811360edy.222.1572392636232; Tue, 29 Oct 2019 16:43:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572392636; cv=none; d=google.com; s=arc-20160816; b=n/z9mEJRI52Juv43rOeS+EgFIy6/wCxZGAR8fNV8w9ro023dJl+VWovYflkevP8F0x SMOKeYhbmJVurLvx8hXzgMMsmqIkdf7KN6Pc7TvAjQJAmWX8msc5VOMP142WzbhdRAuE AmsZA7fLV2hkExZyhVvPtYgodUqg+r88fNh7TEMBmVQeIkWg2RdIJ4v9V94zEecfPf5k QPgArr1gKTmKaEtw+xAtEUOxpWl/G6YtO0wAuTSZsZm5+fcG8HQiFfElFwcJwmJYJEf+ oDBUJuNzfma2CgDbE+9kgv949l0vPTZh7slOxBJ52dnEhO/7RhSBcsCElD5oYUWhq5cP 1kKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=g8W9gbX2ywvmlq0qUT/Gj6rq11IyDCz2yHuc/tVp5W4=; b=mgsi46hCpkoBOCyRQb9pYfkN7J6SQu+m3aWp3FsgtU4ny7YienaaB2GkVozFhsIzSN CvX9mAVursig2EeUbpVU4R8RjDSW7VRXIJWkafPNmFtLj9eNB3Y0yQ1AUUhfSzqM9Pfr Yp50+kg03N/NC/kmfnF4dSFCcYCIsHFGvmILfFr6VT4CpGcTGAvhDXAJ8piJIke+Xii5 pgBH0twzrlrA51HmUBUqYhwzrIw0Fp4CN4FhowjSiZgJbc7bqka0gn9sJQPO7jPas54w BXcUby5pmLuvlmx2M1Gb4gQb3mseYi+LQUmPmcZec4Na5kXZ2j+z4mFJ0VpQZTef45vY 54Kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gw21si120642ejb.202.2019.10.29.16.43.32; Tue, 29 Oct 2019 16:43:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbfJ2Xmu (ORCPT + 99 others); Tue, 29 Oct 2019 19:42:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33018 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfJ2Xmu (ORCPT ); Tue, 29 Oct 2019 19:42:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BECA514EBE2D4; Tue, 29 Oct 2019 16:42:49 -0700 (PDT) Date: Tue, 29 Oct 2019 16:42:49 -0700 (PDT) Message-Id: <20191029.164249.1707480773387143512.davem@davemloft.net> To: gustavo@embeddedor.com Cc: epomozov@marvell.com, igor.russkikh@aquantia.com, sergey.samoilenko@aquantia.com, dmitry.bezrukov@aquantia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: aquantia: fix error handling in aq_ptp_poll From: David Miller In-Reply-To: <20191028070447.GA3659@embeddedor> References: <20191028070447.GA3659@embeddedor> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Oct 2019 16:42:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Mon, 28 Oct 2019 02:04:47 -0500 > Fix currenty ignored returned error by properly checking *err* after > calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(). > > Addresses-Coverity-ID: 1487357 ("Unused value") > Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath") > Signed-off-by: Gustavo A. R. Silva Applied.