Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp347748ybx; Tue, 29 Oct 2019 20:00:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGed3lq8x6mwNbfyaragSYRNV95lOMyxZ5UjEbEimZw1RAgJ9tm18JIYHTEapkhr0XtqfX X-Received: by 2002:a17:906:a0f:: with SMTP id w15mr6421588ejf.321.1572404434153; Tue, 29 Oct 2019 20:00:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572404434; cv=none; d=google.com; s=arc-20160816; b=J2hhP+kS4ySqEYZJKeXAzxnycozsH7cSMoGDuDzgQhCD0RH7x1TJfQD/lMtZ5mGlqA Mtp3lLzj1fxhHgMDGW1aBjnr7LezUXDDprljA/rlr6yADnoXbDqOtxYSVMnZB1Tz3qA2 aFzlZHKscQyATha548zsLRufI3e55oh1gecElztCJAMzDgVxKq7YfFATCbG2IqcwHAJe cYZtpX7tMUXcQp8QDd/rBmU9beYXgroR/D/2tnheEr5GXALUTUp6cDKQeSvIEitdmWcP uTJZO4/Jwb9pYcPAgrlMWocdlUxZ0R0G93VRsnVuUHQwsZv4Gk9rrm9NJXn0ombhrUpV y35g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=SKM1g/7Ztl8yl7cDj4QNDx+BIff+zHablnpP1IDdcwg=; b=wnX3FjIREWmPaPaq2+O+dVNWlsobRaFIkX6H/itKJqna5gWUtAzEEf+F39Y7K3THJj exEiOT86MK/gse8uPXjmhmiczRVcJNErnT1qnlbS8T1zW6IikzD6IPQ9/pTxvrUZ43Ct CPCddrFa9iE71plWgcBP3PjTAg+1+hnY1Nh5urdbLITMD/jqaypr/l6eekpZ6TQQo2l5 wv+6iZWwTkYlbAcUw31p8SthUXZu+P7D2Oz6WYyuuQ06m1g9xdRsUIhJk0BgveNKvR9B K+fJZVlfbO+a60dz0+5aJFVkEuYs2W8GiGTIQENOva9iIyEf/ZXTIre/JOmfsLo5Dfo0 A7ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jo12si378382ejb.176.2019.10.29.20.00.10; Tue, 29 Oct 2019 20:00:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbfJ3C7d (ORCPT + 99 others); Tue, 29 Oct 2019 22:59:33 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5223 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbfJ3C7d (ORCPT ); Tue, 29 Oct 2019 22:59:33 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CA582C4A544F66292673; Wed, 30 Oct 2019 10:59:30 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Wed, 30 Oct 2019 10:59:24 +0800 From: zhong jiang To: CC: , , , Subject: [PATCH] wimax: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops Date: Wed, 30 Oct 2019 10:55:34 +0800 Message-ID: <1572404134-45159-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file operation rather than DEFINE_SIMPLE_ATTRIBUTE. It is detected with the help of coccinelle. Signed-off-by: zhong jiang --- drivers/net/wimax/i2400m/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wimax/i2400m/debugfs.c b/drivers/net/wimax/i2400m/debugfs.c index 73f5892..1c640b4 100644 --- a/drivers/net/wimax/i2400m/debugfs.c +++ b/drivers/net/wimax/i2400m/debugfs.c @@ -26,7 +26,7 @@ int debugfs_netdev_queue_stopped_get(void *data, u64 *val) *val = netif_queue_stopped(i2400m->wimax_dev.net_dev); return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_netdev_queue_stopped, +DEFINE_DEBUGFS_ATTRIBUTE(fops_netdev_queue_stopped, debugfs_netdev_queue_stopped_get, NULL, "%llu\n"); @@ -154,7 +154,7 @@ int debugfs_i2400m_suspend_set(void *data, u64 val) result = 0; return result; } -DEFINE_SIMPLE_ATTRIBUTE(fops_i2400m_suspend, +DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_suspend, NULL, debugfs_i2400m_suspend_set, "%llu\n"); @@ -183,7 +183,7 @@ int debugfs_i2400m_reset_set(void *data, u64 val) } return result; } -DEFINE_SIMPLE_ATTRIBUTE(fops_i2400m_reset, +DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_reset, NULL, debugfs_i2400m_reset_set, "%llu\n"); -- 1.7.12.4