Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Steve MacLean <Steve.MacLean@microsoft.com>
To:     Jiri Olsa <jolsa@redhat.com>,
        Steve MacLean <steve.maclean@linux.microsoft.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] perf inject --jit: Remove //anon mmap events
Thread-Topic: [PATCH 3/4] perf inject --jit: Remove //anon mmap events
Thread-Index: AQHVeWQ56mWbZMuS2UKJ/Lfd6rhxc6dIv9oAgCnrv5A=
Date:   Wed, 30 Oct 2019 03:10:23 +0000
Message-ID: <BN8PR21MB136298F3A0852DAC38E05DB3F7600@BN8PR21MB1362.namprd21.prod.outlook.com>
References: <1570049901-115628-1-git-send-email-steve.maclean@linux.microsoft.com>
 <20191003105716.GB23291@krava>
In-Reply-To: <20191003105716.GB23291@krava>
Accept-Language: en-US, en-GB
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=stmaclea@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-10-30T03:10:22.2971541Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=4b46e905-6d17-4bd9-97a8-7e8e04a67f74;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Steve.MacLean@microsoft.com; 
x-originating-ip: [24.163.126.65]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 25f7be97-89cc-4087-6135-08d75ce6b4c6
x-ms-traffictypediagnostic: BN8PR21MB1219:|BN8PR21MB1219:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR21MB12199D823157B64DE9A2E5AEF7600@BN8PR21MB1219.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 02065A9E77
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(376002)(136003)(39860400002)(396003)(366004)(52314003)(54094003)(199004)(189003)(66066001)(229853002)(102836004)(8990500004)(7696005)(2906002)(446003)(54906003)(256004)(110136005)(11346002)(478600001)(10290500003)(74316002)(52536014)(14454004)(33656002)(5660300002)(6506007)(4744005)(10090500001)(486006)(76176011)(476003)(66946007)(316002)(3846002)(8936002)(99286004)(81156014)(55016002)(86362001)(81166006)(9686003)(8676002)(186003)(26005)(6246003)(22452003)(1511001)(71200400001)(66556008)(305945005)(71190400001)(7736002)(4326008)(76116006)(64756008)(66446008)(6116002)(66476007)(6436002)(25786009);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR21MB1219;H:BN8PR21MB1362.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: OLiEBTNeGAptcAIJIpBsGSf2iLDo9XpuUuxJGNejz/6dJnEQmPJnc0dNgvQaWLBY3k+kooEXwrG+MzZ8GP4glXro7rhYdQUbgX0XZVWSD9181ODm0ci6yW4sZvLG+jhYZObIcGDUI3bO7E0wmVAYFuURY0FaAUxqrzAeYDcMbrRFVnk2p+bofaLBqunkLX4pTQAAf/GCxn7MV0k0xqH42G/d9FPEumB2NVe8xl+kRiFJ+dNPtZo39il9yq77CX48ixv+QvxnBxcbt1se1WOCUGz538sI4h0xa8i4ffvKNhmnwZ/r6iWCO9GbPANBEOC6DmVsjWeQ3nlRZG4hnAvRd+cpGmNDB8u2x/o1z48jMnSjv9t3StylE3Xwrn68zB0j0RKQ91T3G/LDZt3OMbwxM2KWqtZGemgP/ZBgzKR0M52M1luJ3YTwL/b3RFBj5+sF
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25f7be97-89cc-4087-6135-08d75ce6b4c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2019 03:10:24.0158
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sNvkKYGqhmZVULJ0tNCxQB/1W9UX+G8SzCSGyGwCQ4gvISm3FLy4y0u6ZE1r082byslDj2Pp6UymC2WAomtpJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR21MB1219
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> anyway, I wonder if you could just use thread::priv flag for that, like:
>
>  thread =3D machine__findnew_thread(machine, pid, pid);
>  if (!thread)
>    bad
>
>  (int) thread->priv =3D 1;
>
> and check on thread->priv when ruling the pid out, should be faster then =
maintain rb tree
>
> thanks,
> jirka

I agree reusing the existing data structure is a better approach. I have dr=
afted a change reusing the void* priv field. It seems looks like it is curr=
ently safe to use during perf inject.

I will test it tomorrow then send the new patch