Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC] vhost_mdev: add network control vq support
To:     Tiwei Bie <tiwei.bie@intel.com>
Cc:     mst@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        dan.daly@intel.com, cunming.liang@intel.com,
        zhihong.wang@intel.com, lingshan.zhu@intel.com
References: <20191029101726.12699-1-tiwei.bie@intel.com>
 <59474431-9e77-567c-9a46-a3965f587f65@redhat.com>
 <20191030061711.GA11968@___>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <39aa9f66-8e58-ea63-5795-7df8861ff3a0@redhat.com>
Date:   Wed, 30 Oct 2019 15:04:37 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191030061711.GA11968@___>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/10/30 =E4=B8=8B=E5=8D=882:17, Tiwei Bie wrote:
> On Tue, Oct 29, 2019 at 06:51:32PM +0800, Jason Wang wrote:
>> On 2019/10/29 =E4=B8=8B=E5=8D=886:17, Tiwei Bie wrote:
>>> This patch adds the network control vq support in vhost-mdev.
>>> A vhost-mdev specific op is introduced to allow parent drivers
>>> to handle the network control commands come from userspace.
>> Probably work for userspace driver but not kernel driver.
> Exactly. This is only for userspace.
>
> I got your point now. In virtio-mdev kernel driver case,
> the ctrl-vq can be special as well.
>

Then maybe it's better to introduce vhost-mdev-net on top?

Looking at the other type of virtio device:

- console have two control virtqueues when multiqueue port is enabled

- SCSI has controlq + eventq

- GPU has controlq

- Crypto device has one controlq

- Socket has eventq

...

Thanks