Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp583144ybx; Wed, 30 Oct 2019 01:28:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKj/nhJTn/h2ZeHUJoHmWNi+Wm6N4VT1QDk/FXFXweZzLYMHjPBWEQ25GeMmgPwuVxCYo7 X-Received: by 2002:aa7:d38e:: with SMTP id x14mr28630110edq.102.1572424133596; Wed, 30 Oct 2019 01:28:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572424133; cv=none; d=google.com; s=arc-20160816; b=EUIE4JYNnfHsLpw/zikzFj6mrl1md+9Rquya6bgkfx4o8EaEfHAtCvspwXJdyAMmYf T+vjPkg0Q6oyKLxx3b6zXoSrtXfN2B2gt2Lsye0gSW/M6ESqjGraZ2/rumvC5rJ04U97 CCLxkhBlAMAVgr7J1Hqm18Z9f5FFGs8m7qpgC6znn+TqL+e1AX6W0EGiFXIWtpmeW0wG IpNIdv+dtRHSAjFiCeEnEAs8Gd6BtRz6jU7OcTUSrZt4qYFgYQtkxlhLGnmau1on76yH niI4oQEHDcP78t/8MiPBxHBbkX1VI8OXB5T6ZA/r32H7pTpDDNWR72QPFuf9qb9PIriw xoHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=uOhDZuVG7kjlgKmIKoylutyOHh3w/CHwNFN41llILUY=; b=oJynEvY4HZfssTOOQXy8k3tDrFbHHc80e4pX4WRQTF/NT1j+0hjoaErYz+vMEYRJna tFf+LacR0C+ta6DzXMH35xFIttpjzr7lwBp/NDxVCqwMrPnKTc3F2ZdI2TVf3N8b3n8r Vww6aVit7AXKgPTNLAwOcO0CN1hAQiY9RwBdcQfkkkUvQkmpBpCnwoepn5VWQpv+vwm6 zCQRAz6TsWrh7tQIANh7rqj2gUFjV5m6SZQ3VTOl4aF+Qb6bMAIHUORNDsrDv+DVdlft fFbzanJueBX1b1nccsw/rPtT78/5cf/DJ9pSTzaZ25tlFA4qBuLf+wOX4/GEHfx52K6m uM8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qx25si773369ejb.407.2019.10.30.01.28.30; Wed, 30 Oct 2019 01:28:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbfJ3I0g (ORCPT + 99 others); Wed, 30 Oct 2019 04:26:36 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5226 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725923AbfJ3I0f (ORCPT ); Wed, 30 Oct 2019 04:26:35 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 48B392B7E56858FA9135; Wed, 30 Oct 2019 16:26:34 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Wed, 30 Oct 2019 16:26:28 +0800 From: zhong jiang To: , CC: , Subject: [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops Date: Wed, 30 Oct 2019 16:22:36 +0800 Message-ID: <1572423756-59943-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file operation rather than DEFINE_SIMPLE_ATTRIBUTE. Signed-off-by: zhong jiang --- lib/fault-inject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 8186ca8..4e61326 100644 --- a/lib/fault-inject.c +++ b/lib/fault-inject.c @@ -164,7 +164,7 @@ static int debugfs_ul_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); static void debugfs_create_ul(const char *name, umode_t mode, struct dentry *parent, unsigned long *value) @@ -182,7 +182,7 @@ static int debugfs_stacktrace_depth_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get, +DEFINE_DEBUGFS_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get, debugfs_stacktrace_depth_set, "%llu\n"); static void debugfs_create_stacktrace_depth(const char *name, umode_t mode, -- 1.7.12.4