Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp616363ybx; Wed, 30 Oct 2019 02:10:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjE+LX8GBP1RltS2N6S9fUVAyl82oYTby+Zsg866zGNSFOONOhx66vBLjC5tHkHbblLsgz X-Received: by 2002:a05:6402:2c5:: with SMTP id b5mr30696646edx.157.1572426657861; Wed, 30 Oct 2019 02:10:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572426657; cv=none; d=google.com; s=arc-20160816; b=NCwvBI7BruauLaoz/+zMcGlgoDBJLg4/9mBWPZSmQ/luT+DZPJ6H/FYxAgfD1vi+zq panwqkR65HTos5w0cmezMPjakfPXOlRft3074uXirg8WZ0BnjxmS3gFVpNz6QvENesDn wdmFYdESblPnFwjDrn56EmRX5tZBtMz/vO5a/WCvYokW5P9HmjtP/sjCSmB2pQrTiXtx DEoEQU0VK0Tys4v1BUHsqMDlsjLwURJ0Y5QwijU7PDPMqZN4jG1E37XgpoeJDYXr4yB7 1HEh1/YoqOc/3dXChEhGyHsX9vL2EW5EfXNjXq8ERiaWsLS5GHCO6mQc1BRyqiRLrYMg lvtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:to:from:date; bh=90FT20nrwfsYqGPF/UCj4pYut8/UiJEZqQrbj9/7How=; b=XKWuyE9FNNMT+LcKPkQaTuRX0BAgxx7WJx9Azu1ahoTfZySK/Bmabb7iijjTtxX+bN AaKAJ3t4bbQG9MO2ZypG9fDhfVhlE4WohneGqkEK91IZzi4Tq1gRx9pJwPqGPHJjbU8n r6YNQepB7TCDzJx/BtVYaBH/E/yYtwGJ7naVNEJ7VQKEsRYI67LxcpxQyDrq1Dqs7vu7 qZDsUbCMV/5iddAgfFlZoqIwBfrE+CtawiyHjyFQsvbfkiXI1r4STOEdFIZbHZodGi2K /iRw76HqGy4pTYg1al9BCKMg9ilVSEcfeqXRhBIlC1nEB1IVGOUVYRTVy7DTUzvyd83J 2Fbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oq14si836647ejb.76.2019.10.30.02.10.34; Wed, 30 Oct 2019 02:10:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbfJ3JJw (ORCPT + 99 others); Wed, 30 Oct 2019 05:09:52 -0400 Received: from mga17.intel.com ([192.55.52.151]:8496 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfJ3JJw (ORCPT ); Wed, 30 Oct 2019 05:09:52 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 02:09:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="198621558" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga008.fm.intel.com with ESMTP; 30 Oct 2019 02:09:51 -0700 Date: Wed, 30 Oct 2019 02:09:51 -0700 From: Sean Christopherson To: Reto Buerki , Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/8] KVM: x86: nVMX GUEST_CR3 bug fix, and then some... Message-ID: <20191030090950.GA12481@linux.intel.com> References: <20190927214523.3376-1-sean.j.christopherson@intel.com> <8414d3e8-9a68-e817-de5a-3e9ca6dc85bb@codelabs.ch> <20191029150304.GA29542@nodbug.lucina.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191029150304.GA29542@nodbug.lucina.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 04:03:04PM +0100, Martin Lucina wrote: > (Cc:s trimmed) > > Hi, > > On Monday, 30.09.2019 at?12:42, Reto Buerki wrote: > > On 9/27/19 11:45 PM, Sean Christopherson wrote: > > > Sean Christopherson (8): > > > KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter > > > KVM: VMX: Skip GUEST_CR3 VMREAD+VMWRITE if the VMCS is up-to-date > > > KVM: VMX: Consolidate to_vmx() usage in RFLAGS accessors > > > KVM: VMX: Optimize vmx_set_rflags() for unrestricted guest > > > KVM: x86: Add WARNs to detect out-of-bounds register indices > > > KVM: x86: Fold 'enum kvm_ex_reg' definitions into 'enum kvm_reg' > > > KVM: x86: Add helpers to test/mark reg availability and dirtiness > > > KVM: x86: Fold decache_cr3() into cache_reg() > > > > > > arch/x86/include/asm/kvm_host.h | 5 +- > > > arch/x86/kvm/kvm_cache_regs.h | 67 +++++++++++++++++------ > > > arch/x86/kvm/svm.c | 5 -- > > > arch/x86/kvm/vmx/nested.c | 14 ++++- > > > arch/x86/kvm/vmx/vmx.c | 94 ++++++++++++++++++--------------- > > > arch/x86/kvm/x86.c | 13 ++--- > > > arch/x86/kvm/x86.h | 6 +-- > > > 7 files changed, 123 insertions(+), 81 deletions(-) > > > > Series: > > Tested-by: Reto Buerki > > Any chance of this series making it into 5.4? Unless I'm looking in the > wrong place, I don't see the changes in either kvm.git or Linus' tree. It's queued up in kvm.git for 5.5. That being said, the first patch should go into 5.4 (it's also tagged for stable). The next round of KVM fixes for 5.4 will probably be delayed due to KVM Forum. Paolo?