Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp622817ybx; Wed, 30 Oct 2019 02:18:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqwnAd3gi9WxJSMCeDsFYWXcZTtB+1e6OExfAcd7Ohuw56wH6gFGPC20a7SayLsaBfU47l5Q X-Received: by 2002:a05:6402:386:: with SMTP id o6mr31281606edv.148.1572427089148; Wed, 30 Oct 2019 02:18:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572427089; cv=none; d=google.com; s=arc-20160816; b=ZiP18jogE00x45rbKTd2wymfyDqS08VVLhP/XZEnUHrE2cjkiZMgQfYZwqQVDMhqDy mODwnSVvyO/KMfXoPj/oHSpYgbegKXi4kX7kWJOJdVX/ANNeD3/mcDul0MQ2MfPGYiBe 9BGJAuioeWFOrWU/R+t+aH40ZTHveuTdS3jR7KAhxqAURmWPourZ543ig5XTi+Ph/MBh APq67pSr2L3s1nlEiaDyxG9GF3A/FqnSEY9pI7stSuzeOddF2trm+3lpLdsWxkCRx71O opY6P/kPthg0RAEmFmTITmziyMu/C60DgwLW48061pC+/FHbYF7zb6BIHa5XjVXCfORd RQrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=PRs3PTIlQyCALEwElztv2QssVb69nlIOyeWF4cRT1fU=; b=I7ZG7aIjgg6ngYnm7s+gAU3U+IL6l7Fopj0mee1XdebbeLK3/qKlbFF6koWC4csdFb 7aQid3ICML5GKmci8go+LZOR5U4EFA3LFwzFgiJFb1de4k+ERn3r+o1dquAOHX0wlrks sYShRe7yhTeFxAIextc54B0cjZqaD5dseKHRBPhzviyHCOOazrYyQaFd36EyNrp57a6M BmF/m+W+TCVlsqmqKOR2giCTkGJDv15SQmjsPMpIgyv4HaiT4Qx95e9BuE+4pP2BvX3X 9jcHzIfKaIn9HGVfUeVKiF1rWwtE0OMjxSlCeT291pu8mosr6ZQVC6ZvCwCmVkTc+Nmr pteQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o57si1008875edc.240.2019.10.30.02.17.45; Wed, 30 Oct 2019 02:18:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbfJ3JRE (ORCPT + 99 others); Wed, 30 Oct 2019 05:17:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:49076 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726028AbfJ3JRE (ORCPT ); Wed, 30 Oct 2019 05:17:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6950FAF99; Wed, 30 Oct 2019 09:17:03 +0000 (UTC) Date: Wed, 30 Oct 2019 10:17:01 +0100 From: Joerg Roedel To: YueHaibing Cc: joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, geert+renesas@glider.be Subject: Re: [PATCH -next] iommu/ipmmu-vmsa: Remove dev_err() on platform_get_irq() failure Message-ID: <20191030091701.GN838@suse.de> References: <20191023135941.15000-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023135941.15000-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 09:59:41PM +0800, YueHaibing wrote: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. > > Signed-off-by: YueHaibing > --- > drivers/iommu/ipmmu-vmsa.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied for v5.4, thanks.