Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] dt-bindings: arm: at91: Document Kizbox2 boards
 binding
To:     Rob Herring <robh@kernel.org>
Cc:     Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        linux-arm-kernel@lists.infradead.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20191017085405.12599-1-kamel.bouhara@bootlin.com>
 <20191017085405.12599-2-kamel.bouhara@bootlin.com>
 <20191029014949.GA22009@bogus>
From:   Kamel Bouhara <kamel.bouhara@bootlin.com>
Message-ID: <3c3b1763-5185-34b6-8f68-bbc153eb916f@bootlin.com>
Date:   Wed, 30 Oct 2019 11:05:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191029014949.GA22009@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 29/10/2019 02:49, Rob Herring wrote:
> On Thu, Oct 17, 2019 at 10:54:04AM +0200, Kamel Bouhara wrote:
>> Document devicetree's bindings for the SAMA5D31 Kizbox2 boards of
>> Overkiz SAS.
>>
>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
>> ---
>>   .../devicetree/bindings/arm/atmel-at91.yaml   | 35 +++++++++++++++++++
>>   1 file changed, 35 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> index c0869cb860f3..7636bf7c2382 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> @@ -80,6 +80,41 @@ properties:
>>             - const: atmel,sama5d3
>>             - const: atmel,sama5
>>   
>> +      - description: Overkiz kizbox2 board without antenna
>> +        items:
>> +          - const: overkiz,kizbox2-0
>> +          - const: atmel,sama5d31
>> +          - const: atmel,sama5d3
>> +          - const: atmel,sama5
>> +
>> +      - description: Overkiz kizbox2 board with one head
>> +        items:
>> +          - const: overkiz,kizbox2-1
>> +          - const: atmel,sama5d31
>> +          - const: atmel,sama5d3
>> +          - const: atmel,sama5
>> +
>> +      - description: Overkiz kizbox2 board with two heads
>> +        items:
>> +          - const: overkiz,kizbox2-2
>> +          - const: atmel,sama5d31
>> +          - const: atmel,sama5d3
>> +          - const: atmel,sama5
>> +
>> +      - description: Overkiz kizbox2 board with three heads
>> +        items:
>> +          - const: overkiz,kizbox2-3
>> +          - const: atmel,sama5d31
>> +          - const: atmel,sama5d3
>> +          - const: atmel,sama5
>> +
>> +      - description: Overkiz kizbox2 board Rev2 with two heads
>> +        items:
>> +          - const: overkiz,kizbox2-rev2
>> +          - const: atmel,sama5d31
>> +          - const: atmel,sama5d3
>> +          - const: atmel,sama5
> 
> These can all be made a single items list with the 1st entry being an
> enum of all the boards. The board description can be a comment.
> 
> Rob
> 
Yes agree, actually it's already done in v2, by the way thanks for the 
review.

-- 
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com